Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO_MERGE] For CI test - update postgresql branch to the latest master #2467

Closed
wants to merge 334 commits into from

Conversation

vttranlina
Copy link
Contributor

@vttranlina vttranlina commented Oct 24, 2024

To update PostgreSQL to the latest master:

Steps:

  • Checkout the latest PostgreSQL and rebase interactively on the latest master.
  • Resolve any conflicts.
  • Adapt PostgreSQL to fix compile code failures.

Green List:

  • CI is green on the PostgreSQL module (use the PostgreSQL Jenkinsfile).
  • CI is green on all modules.

Note:

  • Most conflicts come from the Antora documentation.

chibenwa and others added 30 commits October 24, 2024 10:01
We generate a unique UUID so this is supported.

Note that turns 5 tests on in the PostgresMailboxManager
test suite.
- Use single query to database for fetch total + total unseen
The query looks like:

select
  count(*) as "total_count",
  count(*) filter (where is_seen = $1) as "unseen_count"
from message_mailbox
where mailbox_id = cast($2 as uuid)
- It is a why make lack of test case when run the test (jpaGuiceServerShouldUpdateQuota)
…ase sql validation

- It was created for JPA, with Postgresql we don't need it. (instead of mark @disabled for it)
Fixed by JAMES-2586 Small codestyle refactorings.
…lict

Otherwise, we could retry on other fatal errors like: io.r2dbc.postgresql.ExceptionFactory$PostgresqlBadGrammarException: column "domain" of relation "mailbox" already exists.
vttranlina and others added 16 commits October 24, 2024 10:21
…-cli

GIVEN I run james-cli in kubernetes
THEN the pod crashes and reboots

Because the james-cli runs JVM it catches the environment variables set by James.
As such it always pretouch 3GB of RAM. When added to memory consumed by James it exceeds the limit and pod get's OOM-killed.
- Ref commit: 829a63f [IMPROVEMENT] JMAP use search index relevance as default sort
…Supported

- TODO - Wait to adapt James-3945 to Postgres
Ref commit: 81b61ed
@vttranlina
Copy link
Contributor Author

🍏 CI is green on the PostgreSQL module (use the PostgreSQL Jenkinsfile). 🍏

- Fix java.util.ConcurrentModificationException
- Fix test InMemoryUploadRepositoryTest
@vttranlina
Copy link
Contributor Author

🍏 🍏 🍏 CI is green on all modules.

Copy link
Contributor

@quantranhong1999 quantranhong1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job.

@Arsnael
Copy link
Contributor

Arsnael commented Oct 28, 2024

Good job!

How do we merge that into postgresql? I guess we push this on postgresql branch minus the commit [Update Jenkinsfile master (just for ci test)](https://github.com/apache/james-project/pull/2467/commits/50f8b1ddf1d344f811b2785a6dd3af9af6d43f8d) correct?

@vttranlina
Copy link
Contributor Author

Good job!

How do we merge that into postgresql? I guess we push this on postgresql branch minus the commit [Update Jenkinsfile master (just for ci test)](https://github.com/apache/james-project/pull/2467/commits/50f8b1ddf1d344f811b2785a6dd3af9af6d43f8d) correct?

absolute correct

@Arsnael
Copy link
Contributor

Arsnael commented Oct 28, 2024

Done, will close this for now. Thanks for the work on this guys!

@Arsnael Arsnael closed this Oct 28, 2024
@vttranlina vttranlina deleted the postgresqlRebaseMaster branch December 23, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants