[#416] feat(hdfs): lazy initialization of hdfsShuffleWriteHandler when per-partition concurrent write is enabled #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n per-partition concurrent write is enabled
Codecov Report
@@ Coverage Diff @@
## master #816 +/- ##
============================================
+ Coverage 57.63% 59.03% +1.40%
- Complexity 2058 2061 +3
============================================
Files 306 292 -14
Lines 14871 12912 -1959
Branches 1221 1222 +1
============================================
- Hits 8571 7623 -948
+ Misses 5808 4857 -951
+ Partials 492 432 -60
... and 14 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jerqi
approved these changes
Apr 17, 2023
|
Could you raise a #773 backport pr to branch-0.7? #773 (comment) |
Done. |
CI failed. You can't cherry-pick this pr. You should revert it and raise a new pr. There is conflict with branch 0.7. |
|
I have reverted your mistake commit. You should raise a new pr. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
lazy initialization of
hdfsShuffleWriteHandlerwhen per-partition concurrent write is enabledWhy are the changes needed?
Without this PR, it will create too much unnecessary, when enable the
concurrent write of per-partition and no-race condition.
This PR is to reduce unnecessary handler creation.
Does this PR introduce any user-facing change?
No.
How was this patch tested?