[#772] fix(kerberos): cache proxy user ugi to avoid memory leak #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PTAL @leixm |
Codecov Report
@@ Coverage Diff @@
## master #773 +/- ##
============================================
+ Coverage 63.11% 63.33% +0.21%
- Complexity 1955 1986 +31
============================================
Files 230 231 +1
Lines 11346 11462 +116
Branches 1119 1126 +7
============================================
+ Hits 7161 7259 +98
- Misses 3789 3800 +11
- Partials 396 403 +7
... and 20 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jerqi
reviewed
Mar 28, 2023
common/src/main/java/org/apache/uniffle/common/security/HadoopSecurityContext.java
Show resolved
Hide resolved
Could we modify the description about |
| @@ -75,6 +78,7 @@ public HadoopSecurityContext( | |||
| refreshIntervalSec, | |||
| refreshIntervalSec, | |||
| TimeUnit.SECONDS); | |||
| proxyUserUgiPool = Maps.newConcurrentMap(); | |||
There was a problem hiding this comment.
Should we use JavaUtils here?
|
It seems that we need some extra tests . |
+1. At least, you should test the filesystem instance should be the same for the same proxy users. |
jerqi
reviewed
Mar 28, 2023
common/src/main/java/org/apache/uniffle/common/security/HadoopSecurityContext.java
Outdated
Show resolved
Hide resolved
advancedxy
reviewed
Mar 28, 2023
common/src/main/java/org/apache/uniffle/common/security/HadoopSecurityContext.java
Outdated
Show resolved
Hide resolved
advancedxy
reviewed
Mar 28, 2023
common/src/test/java/org/apache/uniffle/common/security/HadoopSecurityContextTest.java
Outdated
Show resolved
Hide resolved
advancedxy
reviewed
Mar 28, 2023
|
|
||
| FileSystem fileSystem1 = context.runSecured("alex", () -> FileSystem.get(kerberizedHdfs.getConf())); | ||
| FileSystem fileSystem2 = context.runSecured("alex", () -> FileSystem.get(kerberizedHdfs.getConf())); | ||
| assertEquals(fileSystem1, fileSystem2); |
There was a problem hiding this comment.
assertTrue(filesystem1 == fileSystem2)?
I believe it's more about they are the same instance.
advancedxy
reviewed
Mar 28, 2023
leixm
previously approved these changes
Mar 28, 2023
common/src/main/java/org/apache/uniffle/common/security/HadoopSecurityContext.java
Show resolved
Hide resolved
common/src/main/java/org/apache/uniffle/common/security/HadoopSecurityContext.java
Show resolved
Hide resolved
common/src/main/java/org/apache/uniffle/common/security/HadoopSecurityContext.java
Show resolved
Hide resolved
common/src/main/java/org/apache/uniffle/common/security/HadoopSecurityContext.java
Show resolved
Hide resolved
advancedxy
approved these changes
Mar 29, 2023
xianjingfeng
pushed a commit
to xianjingfeng/incubator-uniffle
that referenced
this pull request
Apr 5, 2023
…apache#773) ### What changes were proposed in this pull request? 1. To avoid memory leak by caching of proxy user UGI. ### Why are the changes needed? Fix: apache#772 The Hadoop filesystem instance will be created too many time in cache, which will cause the shuffle server memory leak. As we know, the filesystem cache's key is built by the scheme、authority and UGI. The scheme and authority are not changed every time. But for UGI, if we invoke the createProxyUser, it will always create a new one, that means the every invoking `Filesystem.get()`, it will be cached due to different key. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? 1. Existing UTs 2. Added tests
jerqi
pushed a commit
that referenced
this pull request
Apr 13, 2023
### What changes were proposed in this pull request? 1. To avoid memory leak by caching of proxy user UGI. ### Why are the changes needed? Fix: #772 The Hadoop filesystem instance will be created too many time in cache, which will cause the shuffle server memory leak. As we know, the filesystem cache's key is built by the scheme、authority and UGI. The scheme and authority are not changed every time. But for UGI, if we invoke the createProxyUser, it will always create a new one, that means the every invoking `Filesystem.get()`, it will be cached due to different key. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? 1. Existing UTs 2. Added tests
jerqi
added a commit
that referenced
this pull request
Apr 13, 2023
|
This is a fix. It should be merged branch 0.7. But there is conflict with branch 0.7. Could you raise a pr to branch 0.7? |
zuston
added a commit
that referenced
this pull request
Apr 17, 2023
### What changes were proposed in this pull request? 1. To avoid memory leak by caching of proxy user UGI. ### Why are the changes needed? Fix: #772 The Hadoop filesystem instance will be created too many time in cache, which will cause the shuffle server memory leak. As we know, the filesystem cache's key is built by the scheme、authority and UGI. The scheme and authority are not changed every time. But for UGI, if we invoke the createProxyUser, it will always create a new one, that means the every invoking `Filesystem.get()`, it will be cached due to different key. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? 1. Existing UTs 2. Added tests
jerqi
added a commit
that referenced
this pull request
Apr 17, 2023
zuston
added a commit
to zuston/incubator-uniffle
that referenced
this pull request
Apr 17, 2023
…apache#773) 1. To avoid memory leak by caching of proxy user UGI. Fix: apache#772 The Hadoop filesystem instance will be created too many time in cache, which will cause the shuffle server memory leak. As we know, the filesystem cache's key is built by the scheme、authority and UGI. The scheme and authority are not changed every time. But for UGI, if we invoke the createProxyUser, it will always create a new one, that means the every invoking `Filesystem.get()`, it will be cached due to different key. No. 1. Existing UTs 2. Added tests
zuston
added a commit
that referenced
this pull request
Apr 17, 2023
…773) (#824) ### What changes were proposed in this pull request? 1. To avoid memory leak by caching of proxy user UGI. ### Why are the changes needed? Fix: #772 The Hadoop filesystem instance will be created too many time in cache, which will cause the shuffle server memory leak. As we know, the filesystem cache's key is built by the scheme、authority and UGI. The scheme and authority are not changed every time. But for UGI, if we invoke the createProxyUser, it will always create a new one, that means the every invoking `Filesystem.get()`, it will be cached due to different key. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? 1. Existing UTs 2. Added tests
xianjingfeng
pushed a commit
to xianjingfeng/incubator-uniffle
that referenced
this pull request
Jun 20, 2023
…ory leak (apache#773)" This reverts commit 89c2b92.
xianjingfeng
pushed a commit
to xianjingfeng/incubator-uniffle
that referenced
this pull request
Jun 20, 2023
…apache#773) 1. To avoid memory leak by caching of proxy user UGI. Fix: apache#772 The Hadoop filesystem instance will be created too many time in cache, which will cause the shuffle server memory leak. As we know, the filesystem cache's key is built by the scheme、authority and UGI. The scheme and authority are not changed every time. But for UGI, if we invoke the createProxyUser, it will always create a new one, that means the every invoking `Filesystem.get()`, it will be cached due to different key. No. 1. Existing UTs 2. Added tests
xianjingfeng
pushed a commit
to xianjingfeng/incubator-uniffle
that referenced
this pull request
Jun 20, 2023
…ory leak (apache#773)" This reverts commit 42d9b0a.
xianjingfeng
pushed a commit
to xianjingfeng/incubator-uniffle
that referenced
this pull request
Jun 20, 2023
… leak (apache#773) (apache#824) 1. To avoid memory leak by caching of proxy user UGI. Fix: apache#772 The Hadoop filesystem instance will be created too many time in cache, which will cause the shuffle server memory leak. As we know, the filesystem cache's key is built by the scheme、authority and UGI. The scheme and authority are not changed every time. But for UGI, if we invoke the createProxyUser, it will always create a new one, that means the every invoking `Filesystem.get()`, it will be cached due to different key. No. 1. Existing UTs 2. Added tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Fix: #772
The Hadoop filesystem instance will be created too many time in cache,
which will cause the shuffle server memory leak.
As we know, the filesystem cache's key is built by the scheme、authority and UGI.
The scheme and authority are not changed every time. But for UGI, if we invoke the
createProxyUser, it will always create a new one, that means the every invoking
Filesystem.get(),it will be cached due to different key.
Does this PR introduce any user-facing change?
No.
How was this patch tested?