feat(bulk_load): set move_files as true while ingest files #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hycdong
changed the title
levy5307
approved these changes
Jan 5, 2022
foreverneverer
approved these changes
Jan 5, 2022
hycdong
added a commit
to hycdong/pegasus
that referenced
this pull request
Jan 6, 2022
This was referenced Jan 10, 2022
Closed
hycdong
added a commit
to hycdong/pegasus
that referenced
this pull request
Jan 29, 2022
acelyc111
pushed a commit
that referenced
this pull request
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
This pull request set move_files=true for IngestExternalFileOptions. IngestExternalFileOptions is the option for ingest operation.
As RocksDB code(https://github.com/facebook/rocksdb/blob/v6.6.4/include/rocksdb/options.h#L1443) show:
If IngestExternalFileOptions.move_files = true, ingest will move files, and its default value is false.
I did tests and found that setting move_files as true can speed up ingestion, more details can be found in Test section.
Tests
Target table have 32 partitions, each partition has 16G data to be ingested. In my test, all partitions will ingest at the same time:
Besides, move_files can decrease disk write throughput during ingestion.