This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
fix(bulk_load): update ingestion error handling with move_files mode #1011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hycdong
changed the title
hycdong
changed the title
hycdong
changed the title
levy5307
reviewed
Jan 13, 2022
levy5307
approved these changes
Jan 14, 2022
Smityz
approved these changes
Jan 17, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As apache/incubator-pegasus#877 shows, move files during ingestion will speech up ingestion and decrease disk write throughput. (apache/incubator-pegasus#864)
However, it exposes that in some error handling cases, it is possible to execute an out-dated ingestion request repeated.
In previous
copy_filesmode, it won't have problems, just ingest files repeatly, now ismove_filesmode, once ingestion is succeed, the original files doesn't exist, which will lead to unexpected ingestion failed.This pull request is to update error handling during ingestion, including:
ingestion_request(It will be used in pegasus repo to do ballot check)