feat(hotkey): capture data part2 - declare coarse collector #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acelyc111
added
the
type/config-change
levy5307
reviewed
Oct 20, 2020
levy5307
reviewed
Oct 20, 2020
levy5307
reviewed
Oct 20, 2020
acelyc111
reviewed
Oct 20, 2020
acelyc111
previously approved these changes
Oct 20, 2020
Better to add the default value in PR description. |
acelyc111
previously approved these changes
Oct 21, 2020
levy5307
reviewed
Oct 21, 2020
levy5307
reviewed
Oct 21, 2020
acelyc111
reviewed
Oct 21, 2020
acelyc111
reviewed
Oct 22, 2020
| static int get_bucket_id(dsn::string_view data) | ||
| { | ||
| size_t hash_value = boost::hash_range(data.begin(), data.end()); | ||
| return static_cast<int>(hash_value % FLAGS_data_capture_hash_bucket_num); |
There was a problem hiding this comment.
Calculate hash value of every key may be wastly, is it possible to use https://github.com/XiaoMi/rdsn/blob/master/src/dsn.layer2.thrift#L92 directly?
There was a problem hiding this comment.
In the current design, it can't get this info
acelyc111
previously approved these changes
Oct 22, 2020
acelyc111
previously approved these changes
Oct 26, 2020
hycdong
reviewed
Oct 26, 2020
levy5307
reviewed
Oct 27, 2020
| coarse_data_variance_threshold, | ||
| 3, | ||
| "the threshold of variance calculate to find the outliers"); | ||
|
|
hycdong
approved these changes
Oct 27, 2020
acelyc111
approved these changes
Oct 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the implement of coarse collector
Config changes