add comment && pass ci

apache · Oct 24, 2020 · fb4d1b1 · fb4d1b1
1 parent 6cf069c
commit fb4d1b1
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/rdsn b/rdsn
diff --git a/src/server/hotkey_collector.cpp b/src/server/hotkey_collector.cpp
@@ -24,6 +24,7 @@
 #include "base/pegasus_key_schema.h"
 #include <dsn/dist/fmt_logging.h>
 #include <dsn/utility/flags.h>
+#include <readerwriterqueue/readerwriterqueue.h>
 
 namespace pegasus {
 namespace server {
@@ -54,6 +55,12 @@ DSN_DEFINE_validator(data_capture_hash_bucket_num, [](int32_t bucket_num) -> boo
     return true;
 });
 
+DSN_DEFINE_int32(
+    "pegasus.server",
+    max_seconds_to_detect_hotkey,
+    150,
+    "the max time (in seconds) allowed to capture hotkey, will stop if hotkey's not found");
+
 // 68–95–99.7 rule, same algorithm as hotspot_partition_calculator::stat_histories_analyse
 static bool
 find_outlier_index(const std::vector<uint64_t> &captured_keys, int threshold, int &hot_index)
@@ -92,16 +99,12 @@ find_outlier_index(const std::vector<uint64_t> &captured_keys, int threshold, in
     }
 }
 
+// TODO: (Tangyanzhao) replace it to xxhash
 static int get_bucket_id(dsn::string_view data)
 {
     size_t hash_value = boost::hash_range(data.begin(), data.end());
     return static_cast<int>(hash_value % FLAGS_data_capture_hash_bucket_num);
 }
-DSN_DEFINE_int32(
-    "pegasus.server",
-    max_seconds_to_detect_hotkey,
-    150,
-    "the max time (in seconds) allowed to capture hotkey, will stop if hotkey's not found");
 
 hotkey_collector::hotkey_collector(dsn::replication::hotkey_type::type hotkey_type,
                                    dsn::replication::replica_base *r_base)
+2 −2		include/dsn/dist/replication/replication.codes.h
+0 −9		include/dsn/dist/replication/replication_enums.h
+0 −14		include/dsn/dist/replication/replication_types.h
+3 −3		src/aio/aio_provider.h
+0 −1		src/aio/disk_engine.h
+139 −47		src/aio/native_linux_aio_provider.cpp
+34 −4		src/aio/native_linux_aio_provider.h
+0 −10		src/common/replication_types.cpp
+0 −14		src/meta/meta_data.h
+50 −74		src/meta/meta_split_service.cpp
+71 −115		src/meta/test/meta_split_service_test.cpp
+1 −2		src/nfs/nfs_client_impl.cpp
+2 −2		src/replica/replica.cpp
+0 −5		src/replica/replica_check.cpp
+0 −8		src/replica/replica_config.cpp
+1 −3		src/replica/replication_app_base.cpp
+61 −108		src/replica/split/replica_split_manager.cpp
+2 −4		src/replica/split/replica_split_manager.h
+102 −127		src/replica/split/test/replica_split_test.cpp
+0 −1		src/replica/test/log_file_test.cpp
+0 −2		src/replica/test/mock_utils.h
+0 −11		src/replication.thrift
+7 −10		src/runtime/test/netprovider.cpp