-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rocksdb): Use original CreateCheckpoint and read meta data from meta CF #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acelyc111
changed the title
[rocksdb] use original rocksdb
feat(rocksdb): Use original rocksdb
May 15, 2020
acelyc111
changed the title
feat(rocksdb): Use original rocksdb
feat(rocksdb): Use original CreateCheckpoint and read meta data from meta CF
Jun 29, 2020
hycdong
reviewed
Jun 30, 2020
levy5307
reviewed
Jun 30, 2020
hycdong
previously approved these changes
Jun 30, 2020
levy5307
approved these changes
Jun 30, 2020
hycdong
approved these changes
Jun 30, 2020
Closed
hycdong
pushed a commit
to hycdong/pegasus
that referenced
this pull request
Aug 24, 2020
hycdong
added
the
type/incompatible
Changes that introduced incompatibility to Pegasus.
label
Aug 25, 2020
acelyc111
pushed a commit
that referenced
this pull request
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Ref: #468
We have store meta data(Pegasus data version, last manual compact timestamp, decree) both in RocksDB's manifest and meta column family in version 2.0.0, now we are going to read meta data from meta CF instead of manifest.
Main changes of this PR:
NOTE: Since meta data is still wrote into manifest, so there is no compatibility problems with 2.0.0.
What is changed and how it works?
No user faced changes.
Check List
Tests
Will fail, only allowed from version 2.0.x
Code changes
No
No
No
No
Side effects
No
No
No
Related changes
Yes
Yes
Yes