This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
fix(split): add flush_memtable for copy_checkpoint_to_dir #729
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In pegasus pr 535, we use rocksdb's original API CreateCheckpoint to do checkpoint. In function
copy_checkpoint_to_dir_unsafe
, it will create a checkpoint without flush memtable, code like below:When parent partition prepare states for child to learned, it should create a checkpoint with memtable flushed. As a result, this checkpoint will contain more data, less data will be learned during async-learn stage.
This pull request adds
flush_memtable
option for functioncopy_checkpoint_to_dir
, the pegasus implementation is in pegasus pr 684.