Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scala-client): generate thrift sources for scala client #1662

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

empiredan
Copy link
Contributor

@empiredan empiredan commented Oct 30, 2023

#1663

Scala client depends on java client. Before java client is built, thrift sources
should be generated.

@empiredan empiredan marked this pull request as draft October 30, 2023 11:15
@empiredan empiredan marked this pull request as ready for review October 30, 2023 13:38
@empiredan empiredan merged commit 383ef0f into apache:master Oct 31, 2023
18 checks passed
empiredan added a commit to empiredan/pegasus that referenced this pull request Nov 2, 2023
apache#1663

Scala client depends on java client. Before java client is built, thrift sources
should be generated.
empiredan added a commit that referenced this pull request Nov 2, 2023
)

#1663

Scala client depends on java client. Before java client is built, thrift sources
should be generated.

This PR is to cherry-pick #1662 into v2.5 to solve issue #1663.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants