Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI Workflows on Github failed for Scala client due to missing necessary generated thrift classes #1663

Closed
empiredan opened this issue Oct 30, 2023 · 0 comments
Closed

CI Workflows on Github failed for Scala client due to missing necessary generated thrift classes #1663

empiredan opened this issue Oct 30, 2023 · 0 comments
Labels
build java-client scala-client thrift

Comments

@empiredan
Copy link
Contributor

CI Workflows on Github failed for Scala client, due to missing necessary generated thrift classes as follows:

[INFO] -------------------------------------------------------------
Error:  COMPILATION ERROR : 
[INFO] -------------------------------------------------------------
Error:  /home/runner/work/incubator-pegasus/incubator-pegasus/scala-client/incubator-pegasus/java-client/src/main/java/org/apache/pegasus/operator/negotiation_operator.java:[21,30] error: package org.apache.pegasus.apps does not exist
Error:  /home/runner/work/incubator-pegasus/incubator-pegasus/scala-client/incubator-pegasus/java-client/src/main/java/org/apache/pegasus/operator/negotiation_operator.java:[22,30] error: package org.apache.pegasus.apps does not exist
Error:  /home/runner/work/incubator-pegasus/incubator-pegasus/scala-client/incubator-pegasus/java-client/src/main/java/org/apache/pegasus/operator/negotiation_operator.java:[23,30] error: package org.apache.pegasus.apps does not exist
Error:  /home/runner/work/incubator-pegasus/incubator-pegasus/scala-client/incubator-pegasus/java-client/src/main/java/org/apache/pegasus/operator/client_operator.java:[23,37] error: package org.apache.pegasus.replication does not exist
Error:  /home/runner/work/incubator-pegasus/incubator-pegasus/scala-client/incubator-pegasus/java-client/src/main/java/org/apache/pegasus/operator/negotiation_operator.java:[32,30] error: cannot find symbol
  symbol:   class negotiation_request
  location: class negotiation_operator
Error:  /home/runner/work/incubator-pegasus/incubator-pegasus/scala-client/incubator-pegasus/java-client/src/main/java/org/apache/pegasus/operator/negotiation_operator.java:[58,9] error: cannot find symbol
  symbol:   class negotiation_response
  location: class negotiation_operator
Error:  /home/runner/work/incubator-pegasus/incubator-pegasus/scala-client/incubator-pegasus/java-client/src/main/java/org/apache/pegasus/operator/negotiation_operator.java:[62,10] error: cannot find symbol
  symbol:   class negotiation_request
  location: class negotiation_operator
Error:  /home/runner/work/incubator-pegasus/incubator-pegasus/scala-client/incubator-pegasus/java-client/src/main/java/org/apache/pegasus/operator/negotiation_operator.java:[63,10] error: cannot find symbol
  symbol:   class negotiation_response
  location: class negotiation_operator
Error:  /home/runner/work/incubator-pegasus/incubator-pegasus/scala-client/incubator-pegasus/java-client/src/main/java/org/apache/pegasus/operator/client_operator.java:[109,9] error: cannot find symbol
  symbol:   class request_meta
  location: class client_operator
Error:  /home/runner/work/incubator-pegasus/incubator-pegasus/scala-client/incubator-pegasus/java-client/src/main/java/org/apache/pegasus/client/PegasusTableInterface.java:[26,30] error: package org.apache.pegasus.apps does not exist
Error:  /home/runner/work/incubator-pegasus/incubator-pegasus/scala-client/incubator-pegasus/java-client/src/main/java/org/apache/pegasus/client/PegasusTableInterface.java:[261,46] error: cannot find symbol
  symbol:   class batch_get_request
  location: interface PegasusTableInterface
Error:  /home/runner/work/incubator-pegasus/incubator-pegasus/scala-client/incubator-pegasus/java-client/src/main/java/org/apache/pegasus/client/Mutations.java:[25,30] error: package org.apache.pegasus.apps does not exist
Error:  /home/runner/work/incubator-pegasus/incubator-pegasus/scala-client/incubator-pegasus/java-client/src/main/java/org/apache/pegasus/client/Mutations.java:[26,30] error: package org.apache.pegasus.apps does not exist
Error:  /home/runner/work/incubator-pegasus/incubator-pegasus/scala-client/incubator-pegasus/java-client/src/main/java/org/apache/pegasus/client/PegasusTable.java:[38,30] error: package org.apache.pegasus.apps does not exist
Error:  /home/runner/work/incubator-pegasus/incubator-pegasus/scala-client/incubator-pegasus/java-client/src/main/java/org/apache/pegasus/client/PegasusTable.java:[39,30] error: package org.apache.pegasus.apps does not exist
Error:  /home/runner/work/incubator-pegasus/incubator-pegasus/scala-client/incubator-pegasus/java-client/src/main/java/org/apache/pegasus/client/PegasusTable.java:[40,30] error: package org.apache.pegasus.apps does not exist
Error:  /home/runner/work/incubator-pegasus/incubator-pegasus/scala-client/incubator-pegasus/java-client/src/main/java/org/apache/pegasus/client/PegasusTable.java:[41,30] error: package org.apache.pegasus.apps does not exist
Error:  /home/runner/work/incubator-pegasus/incubator-pegasus/scala-client/incubator-pegasus/java-client/src/main/java/org/apache/pegasus/client/PegasusTable.java:[42,30] error: package org.apache.pegasus.apps does not exist
Error:  /home/runner/work/incubator-pegasus/incubator-pegasus/scala-client/incubator-pegasus/java-client/src/main/java/org/apache/pegasus/client/PegasusTable.java:[43,30] error: package org.apache.pegasus.apps does not exist
Error:  /home/runner/work/incubator-pegasus/incubator-pegasus/scala-client/incubator-pegasus/java-client/src/main/java/org/apache/pegasus/client/PegasusTable.java:[44,30] error: package org.apache.pegasus.apps does not exist
Error:  /home/runner/work/incubator-pegasus/incubator-pegasus/scala-client/incubator-pegasus/java-client/src/main/java/org/apache/pegasus/client/PegasusTable.java:[45,30] error: package org.apache.pegasus.apps does not exist
Error:  /home/runner/work/incubator-pegasus/incubator-pegasus/scala-client/incubator-pegasus/java-client/src/main/java/org/apache/pegasus/client/PegasusTable.java:[46,30] error: package org.apache.pegasus.apps does not exist
Error:  /home/runner/work/incubator-pegasus/incubator-pegasus/scala-client/incubator-pegasus/java-client/src/main/java/org/apache/pegasus/client/PegasusTable.java:[47,30] error: package org.apache.pegasus.apps does not exist
Error:  /home/runner/work/incubator-pegasus/incubator-pegasus/scala-client/incubator-pegasus/java-client/src/main/java/org/apache/pegasus/client/PegasusTable.java:[48,30] error: package org.apache.pegasus.apps does not exist
Error:  /home/runner/work/incubator-pegasus/incubator-pegasus/scala-client/incubator-pegasus/java-client/src/main/java/org/apache/pegasus/client/PegasusTable.java:[49,30] error: package org.apache.pegasus.apps does not exist
Error:  /home/runner/work/incubator-pegasus/incubator-pegasus/scala-client/incubator-pegasus/java-client/src/main/java/org/apache/pegasus/client/PegasusTable.java:[50,30] error: package org.apache.pegasus.apps does not exist
Error:  /home/runner/work/incubator-pegasus/incubator-pegasus/scala-client/incubator-pegasus/java-client/src/main/java/org/apache/pegasus/client/PegasusTable.java:[51,30] error: package org.apache.pegasus.apps does not exist
Error:  /home/runner/work/incubator-pegasus/incubator-pegasus/scala-client/incubator-pegasus/java-client/src/main/java/org/apache/pegasus/rpc/async/TableHandler.java:[41,37] error: package org.apache.pegasus.replication does not exist
Error:  /home/runner/work/incubator-pegasus/incubator-pegasus/scala-client/incubator-pegasus/java-client/src/main/java/org/apache/pegasus/rpc/async/TableHandler.java:[42,37] error: package org.apache.pegasus.replication does not exist
Error:  /home/runner/work/incubator-pegasus/incubator-pegasus/scala-client/incubator-pegasus/java-client/src/main/java/org/apache/pegasus/rpc/async/TableHandler.java:[43,37] error: package org.apache.pegasus.replication does not exist
Error:  /home/runner/work/incubator-pegasus/incubator-pegasus/scala-client/incubator-pegasus/java-client/src/main/java/org/apache/pegasus/client/Mutations.java:[37,21] error: cannot find symbol
  symbol:   class mutate
  location: class Mutations
Error:  /home/runner/work/incubator-pegasus/incubator-pegasus/scala-client/incubator-pegasus/java-client/src/main/java/org/apache/pegasus/client/Mutations.java:[69,14] error: cannot find symbol
  symbol:   class mutate
  location: class Mutations
Error:  /home/runner/work/incubator-pegasus/incubator-pegasus/scala-client/incubator-pegasus/java-client/src/main/java/org/apache/pegasus/tools/WriteLimiter.java:[24,30] error: package org.apache.pegasus.apps does not exist
Error:  /home/runner/work/incubator-pegasus/incubator-pegasus/scala-client/incubator-pegasus/java-client/src/main/java/org/apache/pegasus/client/PegasusTable.java:[484,46] error: cannot find symbol
  symbol:   class batch_get_request
  location: class PegasusTable
Error:  /home/runner/work/incubator-pegasus/incubator-pegasus/scala-client/incubator-pegasus/java-client/src/main/java/org/apache/pegasus/rpc/async/TableHandler.java:[155,30] error: cannot find symbol
  symbol:   class query_cfg_response
  location: class TableHandler
@empiredan empiredan added type/bug This issue reports a bug. java-client scala-client labels Oct 30, 2023
@empiredan empiredan mentioned this issue Oct 30, 2023
Merged
@empiredan empiredan added thrift build and removed type/bug This issue reports a bug. labels Oct 31, 2023
empiredan added a commit that referenced this issue Oct 31, 2023
@empiredan
fix: generate thrift sources for scala client (#1662)
383ef0f 
#1663

Scala client depends on java client. Before java client is built, thrift sources
should be generated.
empiredan added a commit to empiredan/pegasus that referenced this issue Nov 2, 2023
@empiredan
fix: generate thrift sources for scala client (apache#1662)
28b0d13 
apache#1663

Scala client depends on java client. Before java client is built, thrift sources
should be generated.
@empiredan empiredan mentioned this issue Nov 2, 2023
Merged
empiredan added a commit that referenced this issue Nov 2, 2023
@empiredan
fix: generate thrift sources for scala client (cherry-pick #1662) (#1669
0aebd10 
)

#1663

Scala client depends on java client. Before java client is built, thrift sources
should be generated.

This PR is to cherry-pick #1662 into v2.5 to solve issue #1663.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build java-client scala-client thrift
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@empiredan