Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): remove the auto-generated cpp code by thrift compiler #1042

Conversation

shenxingwuying
Copy link
Contributor

@shenxingwuying shenxingwuying commented Jul 8, 2022

Need not save the files generated by thrift in the repo

issue: #1040

@shenxingwuying shenxingwuying force-pushed the dev/remove_files_generated_by_thrift.cpp branch from 560daae to ed5b6e5 Compare July 9, 2022 04:23
@acelyc111 acelyc111 changed the title chore(build) remove some cpp files auto generated by thrift #1040 chore(build): remove some cpp files auto generated by thrift Jul 9, 2022
@acelyc111 acelyc111 changed the title chore(build): remove some cpp files auto generated by thrift chore(build): remove the auto-generated cpp code by thrift compiler Jul 12, 2022
@shenxingwuying shenxingwuying force-pushed the dev/remove_files_generated_by_thrift.cpp branch 2 times, most recently from 8cc0a8e to 4778a4b Compare July 12, 2022 16:38
@acelyc111
Copy link
Member

please rebase the latest master branch to resolve conflicts, thanks

@shenxingwuying shenxingwuying force-pushed the dev/remove_files_generated_by_thrift.cpp branch 2 times, most recently from dffcab5 to 33d02bc Compare July 13, 2022 10:12
@shenxingwuying shenxingwuying force-pushed the dev/remove_files_generated_by_thrift.cpp branch from 33d02bc to 03bb5a6 Compare July 14, 2022 10:06
Copy link
Member

@acelyc111 acelyc111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@acelyc111 acelyc111 merged commit 03befc5 into apache:master Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants