Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The repo contains some files generated by thrift, I think these files need not be added into the repo. #1040

Closed
shenxingwuying opened this issue Jul 8, 2022 · 1 comment
Closed

The repo contains some files generated by thrift, I think these files need not be added into the repo. #1040

shenxingwuying opened this issue Jul 8, 2022 · 1 comment

Comments

@shenxingwuying
Copy link
Contributor

The repo contains some files generated by thrift, I think these files need not be added into the repo.

I'll remove them from cpp and java-client, other clients(go, node...) all depends.
shenxingwuying pushed a commit to shenxingwuying/incubator-pegasus that referenced this issue Jul 8, 2022
chore(build) remove some cpp files auto generated by thrift apache#1040
560daae 
Need not save the files generated by thrift in the repo

issue: apache#1040
@shenxingwuying shenxingwuying mentioned this issue Jul 8, 2022
Merged
@shenxingwuying
Copy link
Contributor Author

shenxingwuying commented Jul 9, 2022 •
edited
Loading

The docker image: apache/pegasus:build-env-centos7, include python.

[root@60b4f6c98078 pegasus]# which python
/usr/bin/python

But in the auto checks envs: https://github.com/apache/incubator-pegasus/runs/7255552881?check_suite_focus=true

no python ?

Skip building third-parties...
./run.sh: line 238: python: command not found

shenxingwuying pushed a commit to shenxingwuying/incubator-pegasus that referenced this issue Jul 9, 2022
chore(build) remove some cpp files auto generated by thrift apache#1040
ed5b6e5 
Need not save the files generated by thrift in the repo

issue: apache#1040
shenxingwuying pushed a commit to shenxingwuying/incubator-pegasus that referenced this issue Jul 12, 2022
chore(build) remove some cpp files auto generated by thrift apache#1040
8cc0a8e 
Need not save the files generated by thrift in the repo

issue: apache#1040
shenxingwuying pushed a commit to shenxingwuying/incubator-pegasus that referenced this issue Jul 12, 2022
chore(build) remove some cpp files auto generated by thrift apache#1040
4778a4b 
Need not save the files generated by thrift in the repo

issue: apache#1040
shenxingwuying pushed a commit to shenxingwuying/incubator-pegasus that referenced this issue Jul 13, 2022
chore(build) remove some cpp files auto generated by thrift apache#1040
70407c7 
Need not save the files generated by thrift in the repo

issue: apache#1040
shenxingwuying pushed a commit to shenxingwuying/incubator-pegasus that referenced this issue Jul 14, 2022
chore(build) remove some cpp files auto generated by thrift apache#1040
f62a602 
Need not save the files generated by thrift in the repo

issue: apache#1040
ZhongChaoqiang pushed a commit to ZhongChaoqiang/incubator-pegasus that referenced this issue Nov 28, 2022
@foreverneverer
feat(dup_enhancement#2): add more follower's info for master meta (ap…
942eae3 
…ache#1040)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shenxingwuying @acelyc111