Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kie-tools#2621: Remove build-kogito-app stage from Kogito images #2682

Merged
merged 6 commits into from
Oct 19, 2024

Conversation

ricardozanini
Copy link
Member

@ricardozanini ricardozanini commented Oct 18, 2024

Fix #2621; In this PR:

  1. Add maven-base as a new dependency to Kogito images that requires building kogito-apps from the source
  2. Add a new Cekit module on these images that will produce a quarkus application from the Kogito SNAPSHOT stream libraries

We might improve the CI if we cache this snapshot on GitHub Actions, avoiding downloading the snapshots from the Apache server.

@ricardozanini ricardozanini marked this pull request as ready for review October 18, 2024 13:59
@ricardozanini
Copy link
Member Author

Turning "Ready for Review" so we can see the CI.

@ricardozanini ricardozanini changed the title Fix kie-tools#2621 - Remove build-kogito-app stage from Kogito images WIP - Fix kie-tools#2621 - Remove build-kogito-app stage from Kogito images Oct 18, 2024
@ricardozanini ricardozanini added the pr: DO NOT MERGE Draft PR, not ready for merging label Oct 18, 2024
@ricardozanini ricardozanini changed the title WIP - Fix kie-tools#2621 - Remove build-kogito-app stage from Kogito images Fix kie-tools#2621 - Remove build-kogito-app stage from Kogito images Oct 18, 2024
@ricardozanini ricardozanini removed the pr: DO NOT MERGE Draft PR, not ready for merging label Oct 18, 2024
Signed-off-by: Ricardo Zanini <[email protected]>
@tiagobento tiagobento changed the title Fix kie-tools#2621 - Remove build-kogito-app stage from Kogito images kie-tools#2621: Remove build-kogito-app stage from Kogito images Oct 19, 2024
@tiagobento tiagobento merged commit f98665c into apache:main Oct 19, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop cloning and building kogito-apps during kogito-*-image packages build scripts on kie-tools
3 participants