EPIC - Issues found during Apache KIE 10.0.0 release candidates verification/votes

[tiagobento]

Many community members helped with verifying the artifacts for 10.0.0 release candidates [1]. Than you ALL for your involvement and dedication! As much as no hard blockers have been found at the moment, many small issues could be addressed to smooth things out a little bit. Here's a compilation of problems I found during my verification, together with issues that other people found during theirs.

Required by IPMC

See IPMC [VOTE] thread for RC1: -didn't pass internal vote-
See IPMC [VOTE] thread for RC2 (canceled): https://lists.apache.org/thread/oz1xfz48jwlw05sdy0wvtnrhn27jc72h
See IPMC [VOTE] thread for RC3 (canceled): https://lists.apache.org/thread/nrq50szwx37doopb23wyq33v0t3bbccg

• Rename release artifacts names to apache-kie-10.0.0-incubating #1531
• Rename DISCLAIMER files to DISCLAIMER-WIP #1532
• Make sure all .zip and .tar.gz artifacts contain LICENSE, NOTICE, and DISCLAIMER-WIP files #1533
• Remove Maven and Gradle wrapper from source #1534
• notice file for drools is not correct #1616 : "NOTICE and LICENSE" in other repos are handled by
  • kie-issues#1613: Add CI :: Check license headers GitHub Actions workflow incubator-kie-optaplanner#3130
  • kie-issues#1613: Add CI :: License headers GitHub Actions workflow incubator-kie-kogito-runtimes#3714
  • kie-issues#1613: Add CI :: Check license headers GitHub Actions workflow incubator-kie-kogito-apps#2111
  • kie-issues#1613: Add CI :: License headers / check GitHub Actions workflow incubator-kie-tools#2746
• notice file in root of source release (10.0.0 - RC3) has wrong year in it #1618
• Review "3rd party Category X or Category B bundled code licenses not listed in LICENSE" for 10.0.0 #1634

Nice to have

1. drools-docs failed on a first run when trying to install Node.js 16 (EOL). We should not only upgrade Node.js to 20 (LTS) but also try and understand what is causing it to fail for the first time.
   -> drools-docs will be excluded from the source distribution: [incubator-kie-issues-1616] notice file for drools is not correct incubator-kie-drools#6155 (comment)
2. Extra argument -Dquarkus.native.additional-build-args=-H:-CheckToolchain needed when building kogito-apps on Arm-based MacBook Pro, with graalvm-jdk-17.0.12+8.1.
3. kie-tools build got stuck on a prompt from Angular about collecting analytics. We need to have this disabled by default.
4. Make "Build instructions" and "How to verify" sections tied to a release. Those instructions will likely change from one release to the other.
5. 999-SNAPSHOT references found on disabled modules on [email protected] (dead code)
6. ✅ FIXED: Remove binaries from test resources on main #1602
7. helm-docs is not listed as a requirement before building 10.0.0 from source.

---

9. ✅ FIXED: kogito-images copying the entire local Maven repository (~/.m2/repository) inside Container images during build, causing build to fail for people with a large local Maven repository. (see kie-tools#2621: Remove build-kogito-app stage from Kogito images incubator-kie-tools#2682)
10. ✅ FIXED: Create and commit a per-repo list of files to be ignored by Apache RAT (see Add .rat-excludes file to each repository #1613).
11. ✅ FIXED: Lots of [WARNING] Could not validate integrity of download from http://172.17.0.2/ when using maven-m2-repo-via-http during kie-tools build. (Fixed for 10.1+, see: apache/incubator-kie-tools@b6b6d3a)
12. ✅ FIXED: Had to install 'requests<2.32.0' with python -m pip install 'requests<2.32.0' before building kogito-images, otherwise it didn't work. (Fixed for 10.1+ since kogito-images has been permanently moved to kie-tools).
13. ✅ FIXED: 999-SNAPSHOT references found on [email protected] (Fixed for 10.1+ since kogito-images has been permanently moved to kie-tools)

---

[1] https://kie.apache.org/docs/community/verify/

---

For reference, here are the internal voting threads:
rc1: https://lists.apache.org/thread/x1q6yz6ybmb4ym6p16bjgcdksfn900sf
rc2: https://lists.apache.org/thread/t72b95d3q1qvcyd7lbqkrt8cdx2cgsp2
rc3: https://lists.apache.org/thread/nxx66ccognnk8fozt4nk11z7g57c7fnb

[tiagobento]

@tkobayas Can you help me understand this quote from https://lists.apache.org/thread/l7gx1wc1lfhkoxg1kwy2pzyp0nv9l2fl?

[x] No compiled archives bundled in source archive. <- it includes some

What are the "compiled archives" you found on our sources? Thanks!

[tkobayas]

@tiagobento

Under incubator-kie-10.0.0-rc2-sources directory,

All jar files:

$ find . -name "*.jar"
./incubator-kie-drools/kie-ci/src/test/resources/kjar/kjar-module-before.jar
./incubator-kie-drools/kie-ci/src/test/resources/kjar/kjar-module-after.jar
./incubator-kie-drools/drools-verifier/drools-verifier-drl/src/test/resources/org/drools/verifier/model.jar
./incubator-kie-drools/drools-compiler/src/test/resources/KAModelTest.jar
./incubator-kie-drools/drools-compiler/src/test/resources/primespoc.jar
./incubator-kie-drools/drools-compiler/src/test/resources/eventing-example.jar
./incubator-kie-drools/drools-compiler/src/test/resources/JarWithSourceFiles.jar
./incubator-kie-drools/drools-test-coverage/test-compiler-integration/src/test/resources/billasurf.jar
./incubator-kie-drools/drools-test-coverage/test-compiler-integration/src/test/resources/only-jar-pojo-not-kjar-no-kmodule-1.0.0.jar
./incubator-kie-drools/drools-test-coverage/test-compiler-integration/src/test/resources/kie-project-simple-1.0.0.jar
./incubator-kie-drools/drools-test-coverage/test-compiler-integration/src/test/resources/org/drools/mvel/compiler/compiler/xml/changeset/changeset.jar
./incubator-kie-drools/drools-test-coverage/test-compiler-integration/src/test/resources/testEnum.jar
./incubator-kie-drools/drools-legacy-test-util/src/test/resources/billasurf.jar
./incubator-kie-drools/efesto/efesto-core/efesto-runtime-manager/efesto-runtime-manager-core/src/test/resources/TestJar.jar
./incubator-kie-drools/efesto/efesto-core/efesto-common-api/src/test/resources/TestJar.jar
./incubator-kie-drools/efesto/efesto-core/efesto-common-core/src/test/resources/TestJar.jar
./incubator-kie-kogito-apps/.mvn/wrapper/maven-wrapper.jar
./incubator-kie-kogito-runtimes/.mvn/wrapper/maven-wrapper.jar
./incubator-kie-kogito-runtimes/kogito-codegen-modules/kogito-codegen-core/src/test/resources/empty.jar
./incubator-kie-kogito-runtimes/quarkus/integration-tests/integration-tests-quarkus-gradle/integration-tests-quarkus-gradle-project/gradle/wrapper/gradle-wrapper.jar
./incubator-kie-tools/packages/stunner-editors/errai-ui/src/test/resources/less.jar

jar files containing .class files:

$ find . -name "*.jar" -exec sh -c 'unzip -l "{}" | grep -q "\.class" && echo {}' \;
./incubator-kie-drools/drools-verifier/drools-verifier-drl/src/test/resources/org/drools/verifier/model.jar
./incubator-kie-drools/drools-compiler/src/test/resources/KAModelTest.jar
./incubator-kie-drools/drools-compiler/src/test/resources/primespoc.jar
./incubator-kie-drools/drools-compiler/src/test/resources/eventing-example.jar
./incubator-kie-drools/drools-compiler/src/test/resources/JarWithSourceFiles.jar
./incubator-kie-drools/drools-test-coverage/test-compiler-integration/src/test/resources/billasurf.jar
./incubator-kie-drools/drools-test-coverage/test-compiler-integration/src/test/resources/only-jar-pojo-not-kjar-no-kmodule-1.0.0.jar
./incubator-kie-drools/drools-test-coverage/test-compiler-integration/src/test/resources/testEnum.jar
./incubator-kie-drools/drools-legacy-test-util/src/test/resources/billasurf.jar
./incubator-kie-kogito-apps/.mvn/wrapper/maven-wrapper.jar
./incubator-kie-kogito-runtimes/.mvn/wrapper/maven-wrapper.jar
./incubator-kie-kogito-runtimes/quarkus/integration-tests/integration-tests-quarkus-gradle/integration-tests-quarkus-gradle-project/gradle/wrapper/gradle-wrapper.jar

I thought that test resources are acceptable. Should they be changed? (e.g. generate the jars during maven build)

[tiagobento]

@tkobayas Hi! Just reminding you of the existence of this EPIC. I'm trying to keep it up-to-date, but if you find something that is not here, please feel free to edit it's description directly! Thank you! 😊