Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove binaries from test resources on main #1602

Closed
porcelli opened this issue Nov 2, 2024 · 8 comments
Closed

Remove binaries from test resources on main #1602

porcelli opened this issue Nov 2, 2024 · 8 comments

Comments

@porcelli
Copy link
Contributor

porcelli commented Nov 2, 2024

Based on recent comment from @justinmclean [1][2] - we need properly remove binaries (compiled code) from our test resources.

[1] https://lists.apache.org/thread/3176kvtgo0o9cljyzsc3dqj6svrxpd21
[2] https://lists.apache.org/thread/q6zp3v3lwxslh0mmydyzlb22r5ght2p8

Related issue: #1601

@tiagobento
Copy link

https://github.com/apache/incubator-kie-tools/blob/main/packages/dev-deployment-upload-service/tests/test.zip doesn't contain any compiled code, so I guess we can keep it on main. Nothing against removing it on 10.0.x though, if it helps the release.

@porcelli
Copy link
Contributor Author

porcelli commented Nov 3, 2024

@tiagobento we then need to add a NOTICE-BINARY file to justify it, for 10.0.0 better remove all the friction...

@porcelli
Copy link
Contributor Author

porcelli commented Nov 4, 2024

@jomarko
Copy link

jomarko commented Nov 4, 2024

Thank you for tracking integration-tests-quarkus-gradle/pom.xml comment @porcelli . Feel free to add me as reviewer for #1602 if needed once opened.

@tkobayas tkobayas self-assigned this Nov 5, 2024
@tkobayas
Copy link

tkobayas commented Nov 5, 2024

Hi @porcelli , we will rewrite the tests in main branch so that we don't need to have binaries in the codebase. But 10.0.x branch will go with disabling the tests, correct? (= we will not backport the rewrite-fix to 10.0.x)

@porcelli
Copy link
Contributor Author

porcelli commented Nov 5, 2024

thank you @tkobayas - for 10.0.x I already addressed removing and disabling everything. We just need address this on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants