-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove binaries from test resources on main #1602
Comments
https://github.com/apache/incubator-kie-tools/blob/main/packages/dev-deployment-upload-service/tests/test.zip doesn't contain any compiled code, so I guess we can keep it on |
@tiagobento we then need to add a NOTICE-BINARY file to justify it, for 10.0.0 better remove all the friction... |
Hi @porcelli , we will rewrite the tests in |
thank you @tkobayas - for 10.0.x I already addressed removing and disabling everything. We just need address this on main. |
Based on recent comment from @justinmclean [1][2] - we need properly remove binaries (compiled code) from our test resources.
[1] https://lists.apache.org/thread/3176kvtgo0o9cljyzsc3dqj6svrxpd21
[2] https://lists.apache.org/thread/q6zp3v3lwxslh0mmydyzlb22r5ght2p8
Related issue: #1601
The text was updated successfully, but these errors were encountered: