Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kie-issues#883: On the DMN Editor, allow deleting DRDs #2230

Merged
merged 7 commits into from
Apr 10, 2024
Merged

kie-issues#883: On the DMN Editor, allow deleting DRDs #2230

merged 7 commits into from
Apr 10, 2024

Conversation

tiagobento
Copy link
Contributor

@tiagobento tiagobento commented Apr 8, 2024 •
edited
Loading

Closes apache/incubator-kie-issues#883

image

Also on this PR:

  • Little improvements to the Documentation links component. (https instead of http, and padding)
  • More consistent strokeWidth on the alternative InputData node icon
  • Allow changing InputData node shape even on the default DRD.
  • Added EmptyState to the DRG nodes panel
  • Added EmptyState to the DRD selector panel
image image image

@tiagobento tiagobento requested a review from ljmotta April 8, 2024 23:00
@thiagoelg
Copy link
Member

About the CI failing:

My guess is that stream-browserify is not a direct dependency of dmn-vscode-extension, BUT it's an indirect dependency of dev-deployment-dmn-form-webapp. Since this is a partial build, the partial bootstrap is not installing dev-deployment-dmn-form-webapp dependencies, therefore not installing stream-browserify.

The fix would be to include "stream-browserify": "ˆ3.0.0" as a dmn-vscode-extension devDependency.

@tiagobento
Copy link
Contributor Author

@thiagoelg Yeah... it makes sense that it is not working for the partial build.... but it doesn't make sense that it does work for the full build....

ljmotta
ljmotta approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@ljmotta ljmotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking great! nice additions @tiagobento !

packages/dmn-editor/src/diagram/DrdSelectorPanel.tsx Show resolved Hide resolved
@tiagobento tiagobento mentioned this pull request Apr 9, 2024
Merged
@tiagobento tiagobento mentioned this pull request Apr 10, 2024
Merged
@tiagobento tiagobento merged commit c72aba4 into apache:main Apr 10, 2024
8 checks passed
fantonangeli pushed a commit to fantonangeli/kie-tools that referenced this pull request Apr 23, 2024
@tiagobento @thiagoelg @fantonangeli
kie-issues#883: On the DMN Editor, allow deleting DRDs + `extend-node…
1805ef6 
…-path=false` for safer `node_modules` structure (apache#2230)

Co-authored-by: Thiago Lugli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljmotta ljmotta ljmotta approved these changes

@thiagoelg thiagoelg thiagoelg approved these changes

@ederign ederign Awaiting requested review from ederign

@paulovmr paulovmr Awaiting requested review from paulovmr

Assignees
No one assigned
Labels
area:dmn
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

On the DMN Editor, allow deleting DRDs
3 participants
@tiagobento @thiagoelg @ljmotta