kie-issues#946: Action plan - Exploratory phase of the strategy for implementing the E2E test suite for the new DMN Editor - Part 3 #2211

ljmotta · 2024-03-26T13:12:08Z

Related to apache/incubator-kie-issues#946

This PR continues the exploratory phase and continue the work started on #2158

Description

This PR creates introduce and fix a few things:

Use the transform over zoom due to Playwright compatibility.
Set a y offset to the viewport.
Remove variable from Knowledge Source nodes.
Add add[Edge]Waypoint tests.
Add delete[Edge]Waypoint tests.
Add invalid[Edge] tests.
Add jsonModel validation for simple cases.

Improvements for the next interation

Add Decision Service node tests
Add property panel tests
Add resize node tests
Improve json model fixture and tests

* Update addAssociationWaypoint.spec.ts * simplify edges fixture * report webkit issue and skip current test on it * authority requirement * information requirement * remove .only() * knowledge requirement

* Split move and add waypoint tests * refactor edges fixtures

* Introduce delete[edge]Waypoint.spec.ts * finish deleteEdgeWaypoint.spec.ts * fix tests after merging with feature branch * test delete waypoint without its movement * Update packages/dmn-editor/tests/e2e/drgRequirements/deleteAuthorityRequirementWaypoint.spec.ts Co-authored-by: Luiz João Motta <[email protected]> * Update packages/dmn-editor/tests/e2e/drgRequirements/deleteAuthorityRequirementWaypoint.spec.ts Co-authored-by: Luiz João Motta <[email protected]> * do not use new line in given phase * test names simplified and unified * introduce addWaypoint2 fixture * addAssociationWaypoint * use new 'addWaypoint' fixture --------- Co-authored-by: Luiz João Motta <[email protected]>

* initialize spec file * invalid edge tests * remove not needed test * drop 'From' from test describe * fix GROUP tests * fix test describe - remove From * add dim tests * refactor dimmed class assertion * incorporate review feedback * remove custom assertion * add dimmed class to the DOM top level lement of the InputData node * test alternative input data shape

…-main

…e node

jomarko

I found some parts that we need to address probably. Please take a look when you have a moment and also sorry, probably myself is the author of problematic lines.

jomarko · 2024-03-27T08:24:07Z

packages/dmn-editor/tests/e2e/__fixtures__/jsonModel/drgElements.ts

+export enum DataType {
+  Undefined = "<Undefined>",
+  Any = "Any",
+  Boolean = "boolean",
+  Context = "context",
+  Date = "date",
+  DateTime = "date and time",
+  DateTimeDuration = "days and time duration",
+  Number = "number",
+  String = "string",
+  Time = "time",
+  YearsMonthsDuration = "years and months duration",
+}


I think we have this in __fixtures__/jsonModel.ts

jomarko · 2024-03-27T08:29:46Z

packages/dmn-editor/tests/e2e/__fixtures__/nodes.ts

+  public async startDraggingEdge(args: { from: string; edgeType: EdgeType }) {
+    await this.select({ name: args.from, position: NodePosition.TOP });
+    await this.get({ name: args.from }).getByTitle(this.getAddEdgeTitle(args.edgeType)).hover();
+    await this.page.mouse.down();
+  }


Suggested change

public async startDraggingEdge(args: { from: string; edgeType: EdgeType }) {

await this.select({ name: args.from, position: NodePosition.TOP });

await this.get({ name: args.from }).getByTitle(this.getAddEdgeTitle(args.edgeType)).hover();

await this.page.mouse.down();

}

/**

* Used for testing invalid edges. No edge is created using this method.

*/

public async startDraggingEdge(args: { from: string; edgeType: EdgeType }) {

await this.select({ name: args.from, position: NodePosition.TOP });

await this.get({ name: args.from }).getByTitle(this.getAddEdgeTitle(args.edgeType)).hover();

await this.page.mouse.down();

}

jomarko · 2024-03-27T08:45:05Z

packages/dmn-editor/tests/e2e/drgRequirements/invalidAuthorityRequirement.spec.ts

+      });
+    });
+
+    test("shouldn't add an Authority Requirement edge from Input Data node to Input Data node", async ({


Suggested change

test("shouldn't add an Authority Requirement edge from Input Data node to Input Data node", async ({

test("shouldn't add an Authority Requirement edge from Knowledge Source node to Input Data node", async ({

jomarko · 2024-03-27T08:45:54Z

packages/dmn-editor/tests/e2e/drgRequirements/invalidAuthorityRequirement.spec.ts

+      await expect(nodes.get({ name: DefaultNodeName.INPUT_DATA })).toHaveClass(/.*dimmed/);
+    });
+
+    test("shouldn't add an Authority Requirement edge from Input Data node to Decision Service node", async ({


Suggested change

test("shouldn't add an Authority Requirement edge from Input Data node to Decision Service node", async ({

test("shouldn't add an Authority Requirement edge from Knowledge Source node to Decision Service node", async ({

jomarko · 2024-03-27T08:46:25Z

packages/dmn-editor/tests/e2e/drgRequirements/invalidAuthorityRequirement.spec.ts

+      await expect(nodes.get({ name: DefaultNodeName.DECISION_SERVICE })).toHaveClass(/.*dimmed/);
+    });
+
+    test("shouldn't add an Authority Requirement edge from Input Data node to Group node", async ({


Suggested change

test("shouldn't add an Authority Requirement edge from Input Data node to Group node", async ({

test("shouldn't add an Authority Requirement edge from Knowledge Source node to Group node", async ({

jomarko · 2024-03-27T08:46:52Z

packages/dmn-editor/tests/e2e/drgRequirements/invalidAuthorityRequirement.spec.ts

+      await expect(nodes.get({ name: DefaultNodeName.GROUP })).toHaveClass(/.*dimmed/);
+    });
+
+    test("shouldn't add an Authority Requirement edge from Input Data node to Text Annotation node", async ({


Suggested change

test("shouldn't add an Authority Requirement edge from Input Data node to Text Annotation node", async ({

test("shouldn't add an Authority Requirement edge from Knowledge Source node to Text Annotation node", async ({

jomarko · 2024-03-27T08:48:57Z

packages/dmn-editor/tests/e2e/drgRequirements/invalidKnowledgeRequirement.spec.ts

+      });
+    });
+
+    test("shouldn't add an Knowledge Requirement edge from Input Data node to Input Data node", async ({


Suggested change

test("shouldn't add an Knowledge Requirement edge from Input Data node to Input Data node", async ({

test("shouldn't add an Knowledge Requirement edge from BKM node to Input Data node", async ({

jomarko · 2024-03-27T08:49:31Z

packages/dmn-editor/tests/e2e/drgRequirements/invalidKnowledgeRequirement.spec.ts

+      await expect(nodes.get({ name: DefaultNodeName.INPUT_DATA })).toHaveClass(/.*dimmed/);
+    });
+
+    test("shouldn't add an Knowledge Requirement edge from Input Data node to Knowledge Source node", async ({


Suggested change

test("shouldn't add an Knowledge Requirement edge from Input Data node to Knowledge Source node", async ({

test("shouldn't add an Knowledge Requirement edge from BKM node to Knowledge Source node", async ({

jomarko · 2024-03-27T08:49:49Z

packages/dmn-editor/tests/e2e/drgRequirements/invalidKnowledgeRequirement.spec.ts

+      await expect(nodes.get({ name: DefaultNodeName.KNOWLEDGE_SOURCE })).toHaveClass(/.*dimmed/);
+    });
+
+    test("shouldn't add an Knowledge Requirement edge from Input Data node to Group node", async ({


Suggested change

test("shouldn't add an Knowledge Requirement edge from Input Data node to Group node", async ({

test("shouldn't add an Knowledge Requirement edge from BKM node to Group node", async ({

jomarko · 2024-03-27T08:50:09Z

packages/dmn-editor/tests/e2e/drgRequirements/invalidKnowledgeRequirement.spec.ts

+      await expect(nodes.get({ name: DefaultNodeName.GROUP })).toHaveClass(/.*dimmed/);
+    });
+
+    test("shouldn't add an Knowledge Requirement edge from Input Data node to Text Annotation node", async ({


Suggested change

test("shouldn't add an Knowledge Requirement edge from Input Data node to Text Annotation node", async ({

test("shouldn't add an Knowledge Requirement edge from BKM node to Text Annotation node", async ({

jomarko

Thank you for updates

tiagobento · 2024-03-28T17:52:19Z

@ljmotta Looking at the jsonModel.ts fixture you introduced, I have a couple of thoughts:

The wait mechanism is flawed, we can do better with a new optional prop called onModelDebounceStateChanged only render the JSON once debounce is completed.
The drgElements.ts file has too much logic. IMHO we shouldn't be abstracting direct access to the JSON model itself. IMHO it's alright to use hard-coded indexes to find stuff in the array, as we expect that the JSON model will be stable.
The strategy of using the DOM to make the JSON available to the tests is a clever hack, well done.

…-main

tiagobento · 2024-04-09T21:50:19Z

@ljmotta I'm having the exact same problem at #2230, I'll fix it there and this PR should go back to working normally.

tiagobento · 2024-04-10T23:55:24Z

#2230 merged. I already re-triggered the CI here.

…mplementing the E2E test suite for the new DMN Editor - Part 3 (apache#2211) Co-authored-by: Jozef Marko <[email protected]>

ljmotta and others added 12 commits March 8, 2024 11:28

Add xml property to storybook

19d3655

Update add[Edge]Waypoint.spec.ts (#22)

65c5ef3

* Update addAssociationWaypoint.spec.ts * simplify edges fixture * report webkit issue and skip current test on it * authority requirement * information requirement * remove .only() * knowledge requirement

WIP Validate the JSON model from the DMN Editor

616670e

WIP json model validation

3295f45

Split move and add waypoint tests (#23)

71db810

* Split move and add waypoint tests * refactor edges fixtures

Skip the knowledge source tests

c3ae19a

Change zoom to transform due to Playwright compatibility

58e41fe

Merge remote-tracking branch 'origin/main' into kie-issues-946-part-3…

016c9af

…-main

Improve jsonModel fixture, and remove "variable" from knowledge sourc…

b8c5bb4

…e node

Refinement

efbea6f

ljmotta requested review from ederign, tiagobento and paulovmr as code owners March 26, 2024 13:12

ljmotta temporarily deployed to ci March 26, 2024 13:12 — with GitHub Actions Inactive

ljmotta added the area:dmn label Mar 26, 2024

ljmotta assigned jomarko and ljmotta Mar 26, 2024

jomarko reviewed Mar 27, 2024

View reviewed changes

Code review

a3d0499

ljmotta temporarily deployed to ci March 28, 2024 00:38 — with GitHub Actions Inactive

jomarko approved these changes Mar 28, 2024

View reviewed changes

Update screenshots

06e3bdf

ljmotta temporarily deployed to ci March 28, 2024 15:18 — with GitHub Actions Inactive

tiagobento approved these changes Mar 28, 2024

View reviewed changes

ljmotta added 2 commits April 8, 2024 16:44

Merge remote-tracking branch 'origin/main' into kie-issues-946-part-3…

8ec7b32

…-main

Code review

989597c

tiagobento mentioned this pull request Apr 10, 2024

kie-issues#235: Implement DMN 1.4 Boxed conditional expression #2234

Merged

tiagobento merged commit 8a8d331 into apache:main Apr 11, 2024
8 checks passed

ljmotta mentioned this pull request May 6, 2024

EPIC - Action plan of strategy for implementing the E2E test suite for the new DMN Editor apache/incubator-kie-issues#945

Open

70 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

kie-issues#946: Action plan - Exploratory phase of the strategy for implementing the E2E test suite for the new DMN Editor - Part 3 #2211

kie-issues#946: Action plan - Exploratory phase of the strategy for implementing the E2E test suite for the new DMN Editor - Part 3 #2211

ljmotta commented Mar 26, 2024

jomarko left a comment

jomarko Mar 27, 2024

jomarko Mar 27, 2024

jomarko Mar 27, 2024

jomarko Mar 27, 2024

jomarko Mar 27, 2024

jomarko Mar 27, 2024

jomarko Mar 27, 2024

jomarko Mar 27, 2024

jomarko Mar 27, 2024

jomarko Mar 27, 2024

jomarko left a comment •

edited

Loading

tiagobento commented Mar 28, 2024

tiagobento commented Apr 9, 2024

tiagobento commented Apr 10, 2024

	test("shouldn't add an Authority Requirement edge from Input Data node to Input Data node", async ({
	test("shouldn't add an Authority Requirement edge from Knowledge Source node to Input Data node", async ({

	test("shouldn't add an Knowledge Requirement edge from Input Data node to Input Data node", async ({
	test("shouldn't add an Knowledge Requirement edge from BKM node to Input Data node", async ({

kie-issues#946: Action plan - Exploratory phase of the strategy for implementing the E2E test suite for the new DMN Editor - Part 3 #2211

kie-issues#946: Action plan - Exploratory phase of the strategy for implementing the E2E test suite for the new DMN Editor - Part 3 #2211

Conversation

ljmotta commented Mar 26, 2024

Description

Improvements for the next interation

jomarko left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jomarko left a comment • edited Loading

Choose a reason for hiding this comment

tiagobento commented Mar 28, 2024

tiagobento commented Apr 9, 2024

tiagobento commented Apr 10, 2024

jomarko left a comment •

edited

Loading