kie-issues#808: kn-plugin cli version 10.0.0 #2136
Conversation
tiagobento
changed the title
| @@ -42,6 +43,9 @@ func NewGenManifest() *cobra.Command { | |||
| # Persist the generated Operator manifests on a default path (default ./manifests) | |||
| {{.Name}} gen-manifest | |||
|
|
|||
| # Specify a custom target namespace. (default: kubeclt current namespace; --namespace "" to don't set namespace on your manifest) | |||
There was a problem hiding this comment.
Wondering if it'd be better to provide a --skip-namespace arg or something like that.
It might avoid confusion since it's self-explanatory.
I understand this adds extra work, so it's just an idea.
There was a problem hiding this comment.
I'll do that. Actually, I was also considering this extra option. So it would be --namespace {name} or --skip-namespace. That is what you mean?
|
Can we add two more flags to and an option to specify the value for the |
|
Can the generated configmaps use the |
|
@masayag, we can accommodate both on the next releases. https://issues.redhat.com/browse/KOGITO-10052 |
| description: "Quarkus version to be used when creating the SonataFlow project", | ||
| }, | ||
| KN_PLUGIN_WORKFLOW__devModeImage: { | ||
| name: "KN_PLUGIN_WORKFLOW__devModeImage", | ||
| default: "quay.io/kiegroup/kogito-swf-devmode:1.44", | ||
| default: "quay.io/kiegroup/kogito-swf-devmode:latest", |
There was a problem hiding this comment.
We should use the 999-20240218-SNAPSHOT tag here too, no?
There was a problem hiding this comment.
Alright, so there is no timestamped snapshot for this particular image, and we would need to use the kogito-swf-devmode-nightly version of it. However, with apache/incubator-kie-issues#1001, we won't need to deal with it anymore, just pointing to the local image built on kie-tools directly.
ederign
force-pushed
the
KOGITO-9848-2024
branch
from
3b735ef to
3179dff
Compare
| @@ -22,7 +22,7 @@ | |||
| "build:darwin:arm": "pnpm setup:env make build-darwin-arm64", | |||
| "build:dev": "rimraf dist && pnpm build", | |||
| "build:linux": "pnpm setup:env make build-linux-amd64", | |||
| "build:prod": "rimraf dist && run-script-os && pnpm test", | |||
| "build:prod": "rimraf dist && run-script-os && pnpm test && pnpm test:e2e", | |||
…. Trying to isolate the issue
Guys, I think we are ready to merge it. There are some pending tasks yet (moving to new artifacts also Tiago comment related to images), but those can be addressed on later PRs.