Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Quarkus version to 2.5.0.Final #1731

Merged
merged 5 commits into from
Nov 26, 2021
Merged

Conversation

@kie-ci
Copy link
Contributor Author

kie-ci commented Nov 18, 2021

The (build) optaweb-vehicle-routing check has failed. Please check the logs.

@kie-ci
Copy link
Contributor Author

kie-ci commented Nov 18, 2021

The (build) optaplanner-quickstarts check has failed. Please check the logs.

@kie-ci
Copy link
Contributor Author

kie-ci commented Nov 18, 2021

The (build) optaplanner check has failed. Please check the logs.

@kie-ci
Copy link
Contributor Author

kie-ci commented Nov 18, 2021

The (build) kogito-apps check has failed. Please check the logs.

@kie-ci
Copy link
Contributor Author

kie-ci commented Nov 18, 2021

The (build) optaweb-employee-rostering check has failed. Please check the logs.

@kie-ci
Copy link
Contributor Author

kie-ci commented Nov 18, 2021

The (build) kogito-examples check has failed. Please check the logs.

@kie-ci
Copy link
Contributor Author

kie-ci commented Nov 18, 2021

The (build) kogito-runtimes check has failed. Please check the logs.

@kie-ci
Copy link
Contributor Author

kie-ci commented Nov 18, 2021

The (build) optaplanner check has failed. Please check the logs.

@kie-ci
Copy link
Contributor Author

kie-ci commented Nov 18, 2021

The (build) kogito-runtimes check has failed. Please check the logs.

@kie-ci
Copy link
Contributor Author

kie-ci commented Nov 18, 2021

The (build) kogito-examples check has failed. Please check the logs.

@evacchi
Copy link
Contributor

evacchi commented Nov 18, 2021

it looks like something broke in org.kie.kogito.quarkus.dmn.KogitoDMNCodeCodestartIT
located in kogito-quarkus-decisions-extension/kogito-quarkus-decisions-integration-test/src/test/java/org/kie/kogito/quarkus/dmn/KogitoDMNCodeCodestartIT.java

it looks like this line

https://github.com/kiegroup/kogito-runtimes/blob/173b53ac4634dfe2c4c31e6db25c4d52a15f6195/quarkus/extensions/kogito-quarkus-decisions-extension/kogito-quarkus-decisions-integration-test/src/test/java/org/kie/kogito/quarkus/dmn/KogitoDMNCodeCodestartIT.java#L46

no longer generates the correct dep in the generated pom.xml:

   <dependency>
     <groupId>org.kie.kogito</groupId>
     <artifactId>kogito-quarkus-decisions</artifactId>
   </dependency>

instead of

    <dependency>
      <groupId>org.kie.kogito</groupId>
      <artifactId>kogito-quarkus-decisions</artifactId>
      <version>2.0.0-SNAPSHOT</version>
    </dependency>

which is correct on main. This is the approach that we've been using, so it looks like a regression in QuarkusCodestartTest.builder() in 2.5.0.Final (?)

are you aware of this issue @ia3andy ?

@kie-ci
Copy link
Contributor Author

kie-ci commented Nov 18, 2021

The (build) kogito-apps check has failed. Please check the logs.

@evacchi
Copy link
Contributor

evacchi commented Nov 18, 2021

it looks like something changed in the GraphQL API @tiagodolphine @cristianonicolai for data index and job service

@ia3andy
Copy link

ia3andy commented Nov 18, 2021

This might be the reason: quarkusio/quarkus#20892

@ia3andy
Copy link

ia3andy commented Nov 18, 2021

This is a tricky problem, removing the version from the builder call would make it fail to link the codestart, and having the version makes it alter the pom.xml

The problem is on my end, I need to put my head around it.

@kie-ci
Copy link
Contributor Author

kie-ci commented Nov 18, 2021

The (build) kogito-runtimes check has failed. Please check the logs.

@evacchi
Copy link
Contributor

evacchi commented Nov 18, 2021

also @cristianonicolai is there any reason why the last number should be 1.0 in MonitoringIT ?

expected 1.0 at the end:

kogito_process_instance_started_total{app_id="default-process-monitoring-listener",artifactId="integration-tests-quarkus-processes",process_id="monitoring",version="2.0.0-SNAPSHOT",} 1.0

but the log reads:

[2021-11-18T13:34:28.050Z] kogito_process_instance_started_total{app_id="default-process-monitoring-listener",artifactId="integration-tests-quarkus-processes",process_id="monitoring",version="2.0.0-SNAPSHOT",} 0.0

notice 0.0 at the end

running seems correct

[2021-11-18T13:34:28.050Z] kogito_process_instance_running_total{app_id="default-process-monitoring-listener",artifactId="integration-tests-quarkus-processes",process_id="monitoring",version="2.0.0-SNAPSHOT",} 1.0

if we don't really care, I'd trim the "0.0" or "1.0" from the expected string for the time being... and maybe we should try and parse that line instead :P

@kie-ci
Copy link
Contributor Author

kie-ci commented Nov 18, 2021

The (build) kogito-examples check has failed. Please check the logs.

@kie-ci
Copy link
Contributor Author

kie-ci commented Nov 18, 2021

The (build) kogito-apps check has failed. Please check the logs.

@evacchi
Copy link
Contributor

evacchi commented Nov 18, 2021

it looks there is a similar issue for DRL and processes on Examples

expected 1.0 at the end:

kogito_process_instance_started_total{app_id="default-process-monitoring-listener",artifactId="integration-tests-quarkus-processes",process_id="monitoring",version="2.0.0-SNAPSHOT",} 1.0

but the log reads:

[2021-11-18T13:34:28.050Z] kogito_process_instance_started_total{app_id="default-process-monitoring-listener",artifactId="integration-tests-quarkus-processes",process_id="monitoring",version="2.0.0-SNAPSHOT",} 0.0

@kie-ci
Copy link
Contributor Author

kie-ci commented Nov 18, 2021

The (build) kogito-runtimes check has failed. Please check the logs.

@kie-ci
Copy link
Contributor Author

kie-ci commented Nov 18, 2021

The (build) kogito-apps check has failed. Please check the logs.

@kie-ci
Copy link
Contributor Author

kie-ci commented Nov 18, 2021

The (build) kogito-examples check has failed. Please check the logs.

@ia3andy
Copy link

ia3andy commented Nov 19, 2021

This is due to a regression for which I provided a PR on Quarkus core (quarkusio/quarkus#21562):

  • I provided a sustainable solution to @evacchi for 1.5.0.Final (remove the default dependency in the codestart.yml).
  • The next patch version of Quarkus should contain the regression fix (but it's not needed to add the default dependency back in the codestart.yml)

@kie-ci
Copy link
Contributor Author

kie-ci commented Nov 22, 2021

The (build) kogito-examples check has failed. Please check the logs.

@kie-ci
Copy link
Contributor Author

kie-ci commented Nov 22, 2021

The (build) kogito-apps check has failed. Please check the logs.

@radtriste
Copy link
Contributor

jenkins retest this

@kie-ci
Copy link
Contributor Author

kie-ci commented Nov 22, 2021

The (build) kogito-apps check has failed. Please check the logs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

83.3% 83.3% Coverage
0.0% 0.0% Duplication

@radtriste
Copy link
Contributor

jenkins rerun kogito-apps tests

@radtriste
Copy link
Contributor

jenkins rerun kogito-apps tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants