Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KOGITO-6272 Ensure Quarkus extensions do not depend on quarkus-jackson #1726

Closed
wants to merge 3 commits into from

Conversation

evacchi
Copy link
Contributor

@evacchi evacchi commented Nov 17, 2021

While bumping to 2.5.0.CR1 a couple of jackson-related issues were
discovered

  1. we were relying on quarkus-jackson being a dependency; but it was
    transitive from vertx; now vertx removed that dependency and we break
  2. ObjectMapperGenerator is always generated even when resteasy is not
    present
  • fix: add provided dependency to quarkus-jackson
  • ObjectMapperGenerator should be optional (generate only with resteasy present)
  • formatting

Many thanks for submitting your Pull Request ❤️!

Please make sure that your PR meets the following requirements:

  • You have read the contributors guide
  • Your code is properly formatted according to this configuration
  • Pull Request title is properly formatted: KOGITO-XYZ Subject
  • Pull Request title contains the target branch if not targeting main: [0.9.x] KOGITO-XYZ Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains link to any dependent or related Pull Request
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:
  • Run all builds
    Please add comment: Jenkins retest this

  • Run (or rerun) specific test(s)
    Please add comment: Jenkins (re)run [kogito-runtimes|optaplanner|kogito-apps|kogito-examples|optaplanner-quickstarts|optaweb-employee-rostering|optaweb-vehicle-routing] tests

  • Quarkus LTS checks
    Please add comment: Jenkins run LTS

  • Run (or rerun) LTS specific test(s)
    Please add comment: Jenkins (re)run [kogito-runtimes|optaplanner|kogito-apps|kogito-examples|optaplanner-quickstarts|optaweb-employee-rostering|optaweb-vehicle-routing] LTS

  • Native checks
    Please add comment: Jenkins run native

  • Run (or rerun) native specific test(s)
    Please add comment: Jenkins (re)run [kogito-runtimes|optaplanner|kogito-apps|kogito-examples|optaplanner-quickstarts|optaweb-employee-rostering|optaweb-vehicle-routing] native

  • Full Kogito testing (with cloud images and operator BDD testing)
    Please add comment: Jenkins run BDD
    This check should be used only if a big change is done as it takes time to run, need resources and one full BDD tests check can be done at a time ...

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

83.3% 83.3% Coverage
0.0% 0.0% Duplication

@rsynek
Copy link
Contributor

rsynek commented Nov 23, 2021

Hi @evacchi, is there anything I can help with this PR?

@evacchi
Copy link
Contributor Author

evacchi commented Nov 24, 2021

I ended up making quarkus-jackson a dependency here https://github.com/kiegroup/kogito-runtimes/pull/1731

@rsynek
Copy link
Contributor

rsynek commented Nov 24, 2021

I ended up making quarkus-jackson a dependency here #1731

So it will get to OptaPlanner transitively as before? Ok.

@radtriste
Copy link
Contributor

@evacchi anything new on that one ? should be merged ? (but conflict)

@evacchi
Copy link
Contributor Author

evacchi commented Nov 30, 2021

I think it has been addressed as part of https://github.com/kiegroup/kogito-runtimes/pull/1731 @radtriste

@evacchi evacchi closed this Nov 30, 2021
@evacchi evacchi deleted the KOGITO-6272-jackson-fixes branch February 16, 2022 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants