Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1749 - Rename SonataFlow, jBPM, and Drools extensions #1750

Merged
merged 9 commits into from
Apr 2, 2024

Conversation

ricardozanini
Copy link
Member

Many thanks for submitting your Pull Request ❤️!

Please make sure your PR meets the following requirements:

  • You have read the contributors guide
  • Pull Request title is properly formatted: [KOGITO|RHPAM-XYZ] Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
  • Your feature/bug fix has a testcase that verifies it
  • You've tested the new feature/bug fix in an actual OpenShift cluster
  • You've added a RELEASE_NOTES.md entry regarding this change

Closes #1749

CI might fail since we depend on apache/incubator-kie-issues#933

How to retest this PR or trigger a specific build:
  • (Re)run Jenkins tests
    Please add comment: Jenkins [test|retest] this
How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

@apache apache deleted a comment from kie-ci3 Feb 28, 2024
@ricardozanini ricardozanini added the on hold ✋ PR is waiting for external issues label Feb 28, 2024
@apache apache deleted a comment from kie-ci3 Feb 28, 2024
@ricardozanini ricardozanini removed the on hold ✋ PR is waiting for external issues label Mar 12, 2024
@ricardozanini
Copy link
Member Author

@pefernan ptal. I think there are a few changes that I'm not sure if it's correct. Let's sync later.

@wmedvede
Copy link
Contributor

wmedvede commented Mar 13, 2024

For the record:

The changes on swf-devmode and swf-builder images I believe are ok.
I was able to build these images locally, BUT, unfortunately, due to python + cekit local issues I can't execute the tests locally.
CI should be able to do I think.

@apache apache deleted a comment from kie-ci3 Mar 18, 2024
@ricardozanini
Copy link
Member Author

@jakubschwan @jstastny-cz can you guys lend me a hand here? The tests are failing in a simple sh -c 'echo $USER' command. I honestly can't figure out what's possibly happening. Maybe this docker within docker structure we have to have in ASK Jenkins? Locally it runs fine and it was running fine before. I've also tried bash -c, with no luck.

@jstastny-cz
Copy link
Contributor

Unless we can get logs from the container startup it's hard to guess. I don't see any hint in current logs. Does it use the latest SNAPSHOTs and in jvm or native quarkus mode?

@ricardozanini
Copy link
Member Author

Latest snapshots and jvm, no native. I can't get any clue in the logs either.

@ricardozanini
Copy link
Member Author

Opened cekit/cekit#903

@ricardozanini
Copy link
Member Author

@jstastny-cz can we upgrade to Cekit 4.11?

ricardozanini added a commit to ricardozanini/kogito-pipelines that referenced this pull request Mar 19, 2024
Upgrading Cekit 4.11.0 to hopefully unlock apache/incubator-kie-kogito-images#1750
@ricardozanini
Copy link
Member Author

jstastny-cz pushed a commit to apache/incubator-kie-kogito-pipelines that referenced this pull request Mar 19, 2024
@apache apache deleted a comment from kie-ci3 Mar 19, 2024
@ricardozanini
Copy link
Member Author

Apparently, the latest changes on Cekit Behave tests impacted our tests, so I've reverted their changes on my private fork, which worked. I'm waiting for their feedback on what to do.

Signed-off-by: Ricardo Zanini <[email protected]>
@apache apache deleted a comment from kie-ci3 Mar 22, 2024
@apache apache deleted a comment from kie-ci3 Mar 22, 2024
Signed-off-by: Ricardo Zanini <[email protected]>
@apache apache deleted a comment from kie-ci3 Mar 26, 2024
@apache apache deleted a comment from kie-ci3 Mar 26, 2024
Signed-off-by: Ricardo Zanini <[email protected]>
@kie-ci3
Copy link
Contributor

kie-ci3 commented Mar 28, 2024

PR job #131 was: FAILURE
Possible explanation: Pipeline failure or project build failure

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images.build-and-test/131/display/redirect
See console log:

Console Logs [Pipeline] }
[Pipeline] // stage
[Pipeline] }
Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1750 - kogito-data-index-postgresql: https://github.com//pull/1750 completed: SUCCESS
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1750 - kogito-runtime-jvm: https://github.com//pull/1750 completed: SUCCESS
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1750 - kogito-jobs-service-allinone: https://github.com//pull/1750 completed: SUCCESS
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1750 - kogito-jobs-service-ephemeral: https://github.com//pull/1750 completed: SUCCESS
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1750 - kogito-management-console: https://github.com//pull/1750 completed: SUCCESS
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1750 - kogito-swf-builder: https://github.com//pull/1750 completed: SUCCESS
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1750 - kogito-swf-devmode: https://github.com//pull/1750 completed: SUCCESS
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1750 - kogito-s2i-builder: https://github.com//pull/1750 completed: SUCCESS
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] // parallel
[Pipeline] }
[Pipeline] // dir
[Pipeline] }
[Pipeline] // script
[Pipeline] }
[Pipeline] // stage
[Pipeline] stage
[Pipeline] { (Declarative: Post Actions)
[Pipeline] script
[Pipeline] {
[Pipeline] sh
+ wget --no-check-certificate -qO - 'https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images.build-and-test/131/api/json?depth=0'
[Pipeline] readJSON
[Pipeline] sh

@ricardozanini
Copy link
Member Author

@kie-ci3
Copy link
Contributor

kie-ci3 commented Apr 2, 2024

PR job #133 was: UNSTABLE
Possible explanation: This should be test failures

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images.build-and-test/133/display/redirect
See console log:

Console Logs [Pipeline] }
Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1750 - kogito-data-index-ephemeral: https://github.com//pull/1750 completed: SUCCESS
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1750 - kogito-jobs-service-ephemeral: https://github.com//pull/1750 completed: SUCCESS
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1750 - kogito-management-console: https://github.com//pull/1750 completed: SUCCESS
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1750 - kogito-jobs-service-allinone: https://github.com//pull/1750 completed: UNSTABLE
[Pipeline] unstable
WARNING: Tests on kogito-jobs-service-allinone seems to have failed
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1750 - kogito-runtime-jvm: https://github.com//pull/1750 completed: SUCCESS
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1750 - kogito-swf-devmode: https://github.com//pull/1750 completed: SUCCESS
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1750 - kogito-swf-builder: https://github.com//pull/1750 completed: SUCCESS
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
Build KIE » kogito » main » pullrequest » kogito-images.build-image PR #1750 - kogito-s2i-builder: https://github.com//pull/1750 completed: SUCCESS
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] // parallel
[Pipeline] }
[Pipeline] // dir
[Pipeline] }
[Pipeline] // script
[Pipeline] }
[Pipeline] // stage
[Pipeline] stage
[Pipeline] { (Declarative: Post Actions)
[Pipeline] script
[Pipeline] {
[Pipeline] sh
+ wget --no-check-certificate -qO - 'https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest/job/kogito-images.build-and-test/133/api/json?depth=0'
[Pipeline] readJSON
[Pipeline] sh

@porcelli porcelli merged commit b4cf1cb into apache:main Apr 2, 2024
3 of 4 checks passed
@ricardozanini ricardozanini deleted the issue-1749 branch April 3, 2024 12:33
rgdoliveira pushed a commit to rgdoliveira/incubator-kie-kogito-images that referenced this pull request Apr 16, 2024
…che#1750)

* Fix apache#1749 - Rename SonataFlow, jBPM, and Drools extensions

Signed-off-by: Ricardo Zanini <[email protected]>

* Review org.kie.kogito to org.kie namespace

Signed-off-by: Ricardo Zanini <[email protected]>

* Rename to org.apache.kie.sonataflow

Signed-off-by: Ricardo Zanini <[email protected]>

* Fix behave tests log regexp to match extensions descriptions

Signed-off-by: Ricardo Zanini <[email protected]>

* Trying to switch back to sh from bash

Signed-off-by: Ricardo Zanini <[email protected]>

* Changing behave tests fork to experiment with an older cekit version

Signed-off-by: Ricardo Zanini <[email protected]>

* Using jmtd cekit-behave ref

Signed-off-by: Ricardo Zanini <[email protected]>

* Fix devmodeui behave tests

Signed-off-by: Ricardo Zanini <[email protected]>

* Remove cekit-behave workaround

Signed-off-by: Ricardo Zanini <[email protected]>

---------

Signed-off-by: Ricardo Zanini <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename extensions to match the new community policies and match Quarkus Platform
7 participants