Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make DMN Editor's Boxed Expression Editor Context Menu show only relevant operations for specific cells #259

Closed
jomarko opened this issue May 16, 2023 · 0 comments · Fixed by apache/incubator-kie-tools#1652
Closed

Make DMN Editor's Boxed Expression Editor Context Menu show only relevant operations for specific cells #259

jomarko opened this issue May 16, 2023 · 0 comments · Fixed by apache/incubator-kie-tools#1652
Assignees
@jomarko
Labels
area:dmn Related to DMN area:tools Issues affecting Apache KIE tooling projects type:enhancement Something that already exists needs to be improved

Comments

@jomarko
Copy link

jomarko commented May 16, 2023 •
edited by tiagobento
Loading

Take these historical notes into account when making this task:

  • Context Menu broken on DT top-level headers. Column index is broken. E.g. Add to the right/left.
  • "Additional row" context menu broken. Shouldn't have Delete nor Insert below. See Context cells.
  • SELECTION Cut/paste/reset should not be available for header cells on Context Menu.
  • Logic type selector should never render outside the screen. Same for context menu.
  • Context Menu shouldn't be allowed on every cell. Fix it.
  • Menu items 'Reset', 'Copy', 'Cut' and 'Paste' for header cells (header cells of columns, leading row cells of parameters, context entries, generally those containing name and data type) do not work, we should remove them
  • Some places miss 'Duplicate row' option (Relation data cell, Relation row index cell, Invocation parameter header cell, Context entry header cell, List row index cell)

Please fix #324 as part of this issue too.

Related issues
@jomarko jomarko mentioned this issue May 16, 2023
Closed
@jomarko jomarko added type:enhancement Something that already exists needs to be improved area:dmn Related to DMN area:tools Issues affecting Apache KIE tooling projects labels May 16, 2023
@jomarko jomarko moved this to Backlog 💭 (unordered) in IBM and KIE Community Project - Archived! May 16, 2023
@jomarko jomarko changed the title When more than one header cells are selected, the context menu should be able to give options related to the selection, like Google Sheets does. When more than one cell is selected, the context menu should be able to give options related to the selection, like Google Sheets does. May 16, 2023
@jomarko jomarko self-assigned this May 18, 2023
@jomarko jomarko moved this from Backlog 💭 (unordered) to In Progress 🔧 (1 per person) in IBM and KIE Community Project - Archived! May 18, 2023
jomarko added a commit to jomarko/kie-tools that referenced this issue May 19, 2023
@jomarko
kie-issues#259: Adapt context menu content for multiple cell selections
77d671a 
This PR closes: apache/incubator-kie-issues#259
@jomarko jomarko mentioned this issue May 19, 2023
Merged
jomarko added a commit to jomarko/kie-tools that referenced this issue May 19, 2023
@jomarko
kie-issues#259: Adapt context menu content for multiple cell selections
cd21099 
This PR closes: apache/incubator-kie-issues#259
jomarko added a commit to jomarko/kie-tools that referenced this issue May 19, 2023
@jomarko
kie-issues#259: Adapt context menu content for multiple cell selections
527ae1a 
This PR closes: apache/incubator-kie-issues#259
jomarko added a commit to jomarko/kie-tools that referenced this issue May 19, 2023
@jomarko
kie-issues#259: Adapt context menu content for multiple cell selections
e3f282e 
This PR closes: apache/incubator-kie-issues#259
@yesamer yesamer mentioned this issue May 24, 2023
Merged
@jomarko jomarko mentioned this issue May 30, 2023
Closed
@jomarko jomarko moved this from In Progress 🔧 (1 per person) to Ready to take 🫵 (top to bottom) in IBM and KIE Community Project - Archived! May 30, 2023
@jomarko jomarko mentioned this issue Jun 8, 2023
Closed
@tiagobento tiagobento changed the title When more than one cell is selected, the context menu should be able to give options related to the selection, like Google Sheets does. Make DMN Editor's Boxed Expression Editor Context Menu show only relevant operations for specific cells Jun 8, 2023
@jomarko jomarko moved this from Ready to take 🫵 (top to bottom) to In Progress 🔧 (1 per person) in IBM and KIE Community Project - Archived! Jun 9, 2023
@jomarko jomarko moved this from In Progress 🔧 (1 per person) to In Review 🔁 (1 per person) in IBM and KIE Community Project - Archived! Jun 9, 2023
@github-project-automation github-project-automation bot moved this from In Review 🔁 (1 per person) to Done 🎉 in IBM and KIE Community Project - Archived! Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jomarko jomarko

Labels
area:dmn Related to DMN area:tools Issues affecting Apache KIE tooling projects type:enhancement Something that already exists needs to be improved
Projects
None yet
Milestone
No milestone
1 participant
@jomarko