Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In DMN Editor's Boxed Expression Editor Context Menu, make possible to add N rows/columns with a single click #168

Closed
tiagobento opened this issue Apr 14, 2023 · 2 comments · Fixed by apache/incubator-kie-tools#1780
Assignees
Labels
area:dmn Related to DMN area:tools Issues affecting Apache KIE tooling projects type:bug Something is behaving unexpectedly

Comments

@tiagobento
Copy link

tiagobento commented Apr 14, 2023

If user wants to add N columns or rows in Boxed Expression Editor, the user needs to click N times in the add icon or N times in Insert left/right above/below.

Example:
Screenshot 2023-05-16 164607

It should be possible to add N row/columns above/below with few clicks.

### Acceptance criteria:
- [ ] Create an option in Context Menu where user can add add N rows/columns in any direction.
- [ ] Address all FIXMEs referring to this issue (grep codebase for `https://github.com/kiegroup/kie-issues/issues/168`)
@tiagobento tiagobento converted this from a draft issue Apr 14, 2023
@tiagobento tiagobento changed the title Integrate BeeTable's ContextMenu mechanism to cells and selections Make BeeTable's ContextMenu mechanism aware of cells, selections, and the available space on screen Apr 14, 2023
@tiagobento tiagobento added area:dmn Related to DMN type:enhancement Something that already exists needs to be improved labels Apr 14, 2023
@tiagobento tiagobento moved this from Backlog 💭 (unordered) to Ready to take 🫵 (top to bottom) in IBM and KIE Community Project - Archived! Apr 19, 2023
@tiagobento tiagobento moved this from Ready to take 🫵 (top to bottom) to In Progress 🔧 (1 per person) in IBM and KIE Community Project - Archived! Apr 20, 2023
@tiagobento tiagobento moved this from In Progress 🔧 (1 per person) to Ready to take 🫵 (top to bottom) in IBM and KIE Community Project - Archived! Apr 20, 2023
@tiagobento tiagobento moved this from Ready to take 🫵 (top to bottom) to Backlog 💭 (unordered) in IBM and KIE Community Project - Archived! Apr 20, 2023
@tiagobento tiagobento moved this from Backlog 💭 (unordered) to Ready to take 🫵 (top to bottom) in IBM and KIE Community Project - Archived! Apr 20, 2023
@tiagobento tiagobento added type:enhancement Something that already exists needs to be improved and removed type:enhancement Something that already exists needs to be improved labels Apr 28, 2023
@tiagobento
Copy link
Author

tiagobento commented Apr 28, 2023

Let's consider splitting this task in two:

  1. Make BeeTable's ContextMenu mechanism aware of cells and selections (enhancement)
  2. Make BeeTable's ContextMenu mechanism aware of the available space on screen (bug)

@tiagobento tiagobento added type:bug Something is behaving unexpectedly and removed type:enhancement Something that already exists needs to be improved labels Apr 28, 2023
@jomarko jomarko self-assigned this May 15, 2023
@jomarko jomarko moved this from Ready to take 🫵 (top to bottom) to In Progress 🔧 (1 per person) in IBM and KIE Community Project - Archived! May 15, 2023
@jomarko
Copy link

jomarko commented May 15, 2023

Discussed with @danielzhe , we should add one more bullet point for changing context menu look for header cells, when user is about to pick a data type for the cell. In case a lot of custom data types are defined, the current context menu grows to big size.

One of proposals was to use multilevel context menus similar we use in sandbox workspace assets management.

image

@jomarko jomarko moved this from In Progress 🔧 (1 per person) to Ready to take 🫵 (top to bottom) in IBM and KIE Community Project - Archived! May 16, 2023
@jomarko jomarko moved this from Ready to take 🫵 (top to bottom) to In Progress 🔧 (1 per person) in IBM and KIE Community Project - Archived! May 16, 2023
@jomarko jomarko moved this from In Progress 🔧 (1 per person) to Ready to take 🫵 (top to bottom) in IBM and KIE Community Project - Archived! May 18, 2023
@danielzhe danielzhe assigned danielzhe and unassigned jomarko May 19, 2023
@danielzhe danielzhe moved this from Ready to take 🫵 (top to bottom) to In Progress 🔧 (1 per person) in IBM and KIE Community Project - Archived! May 19, 2023
@danielzhe danielzhe moved this from In Progress 🔧 (1 per person) to Ready to take 🫵 (top to bottom) in IBM and KIE Community Project - Archived! Jun 6, 2023
@tiagobento tiagobento added the area:tools Issues affecting Apache KIE tooling projects label Jun 6, 2023
@danielzhe danielzhe moved this from Ready to take 🫵 (top to bottom) to In Progress 🔧 (1 per person) in IBM and KIE Community Project - Archived! Jun 7, 2023
@tiagobento tiagobento changed the title Make BeeTable's ContextMenu mechanism aware of cells, selections, and the available space on screen Make DMN Editor's Boxed Expression Editor Context Menu aware of selection, not only individual cells Jun 8, 2023
@danielzhe danielzhe changed the title Make DMN Editor's Boxed Expression Editor Context Menu aware of selection, not only individual cells In DMN Editor's Boxed Expression Editor Context Menu, make possible to add N rows/columns with a single click Jun 19, 2023
@danielzhe danielzhe moved this from In Progress 🔧 (1 per person) to In Review 🔁 (1 per person) in IBM and KIE Community Project - Archived! Jun 20, 2023
@github-project-automation github-project-automation bot moved this from In Review 🔁 (1 per person) to Done 🎉 in IBM and KIE Community Project - Archived! Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dmn Related to DMN area:tools Issues affecting Apache KIE tooling projects type:bug Something is behaving unexpectedly
Projects
None yet
3 participants