Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pd-store): fix hstore backend core tests failure #2431

Merged
merged 17 commits into from
Feb 27, 2024

Conversation

Pengzna
Copy link
Contributor

@Pengzna Pengzna commented Jan 29, 2024

related issue: #2420
further work of #2424

NOTE:there are still some issues related to MultiGraphTest, EdgeCoreTest, etc. I and @VGalaxies have marked these issues with TODOs in comments, which will be expected to be gradually repaired in the subsequent migration and adaptation work.

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (pd-store@9fc3788). Click here to learn what that means.

Files Patch % Lines
...g/apache/hugegraph/backend/cache/CacheManager.java 0.00% 2 Missing ⚠️
...graph/backend/cache/CachedSchemaTransactionV2.java 0.00% 1 Missing ⚠️
...ava/org/apache/hugegraph/job/schema/SchemaJob.java 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             pd-store    #2431   +/-   ##
===========================================
  Coverage            ?   55.32%           
  Complexity          ?     1905           
===========================================
  Files               ?      718           
  Lines               ?    58318           
  Branches            ?     7489           
===========================================
  Hits                ?    32267           
  Misses              ?    22874           
  Partials            ?     3177           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Pengzna Pengzna marked this pull request as ready for review February 27, 2024 07:43
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. bug Something isn't working tests Add or improve test cases labels Feb 27, 2024
@Pengzna Pengzna changed the title fix(pd-store): fix hstore backend core tests failure [WIP] fix(pd-store): fix hstore backend core tests failure Feb 27, 2024
@VGalaxies VGalaxies merged commit 6db8b08 into apache:pd-store Feb 27, 2024
16 of 17 checks passed
pom.xml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hstore Hstore backend size:M This PR changes 30-99 lines, ignoring generated files. tests Add or improve test cases
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants