-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pd-store): partially fix hstore backend core tests failure #2424
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## pd-store #2424 +/- ##
===========================================
Coverage ? 55.15%
Complexity ? 1901
===========================================
Files ? 718
Lines ? 58294
Branches ? 7484
===========================================
Hits ? 32150
Misses ? 22974
Partials ? 3170 ☔ View full report in Codecov by Sentry. |
@Pengzna, could you take a look at the errors related to |
Thanks your work, I'm working on it |
enhance it in next PR~ |
Purpose of the PR
close #2420
Main Changes
Some tests that are currently failing (not addressed in this PR):
VertexCoreTest
: Not adapted yet.VertexCoreTest
andEdgeCoreTest
: Inconsistency in the definition ofposition
between RocksDB scan iterator and Hstore.RamTableTest
cases: The ramtable feature is not supported by the hstore backend.Verifying these changes
Does this PR potentially affect the following parts?
Documentation Status
Doc - TODO
Doc - Done
Doc - No Need