Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pd-store): partially fix hstore backend core tests failure #2424

Merged
merged 4 commits into from
Jan 29, 2024

Conversation

VGalaxies
Copy link
Contributor

@VGalaxies VGalaxies commented Jan 21, 2024

Purpose of the PR

close #2420

Main Changes

Some tests that are currently failing (not addressed in this PR):

  1. Tests related to OLAP in VertexCoreTest: Not adapted yet.
  2. Tests related to page in VertexCoreTest and EdgeCoreTest: Inconsistency in the definition of position between RocksDB scan iterator and Hstore.
  3. Some RamTableTest cases: The ramtable feature is not supported by the hstore backend.
  4. ...

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows:
    • CI

Does this PR potentially affect the following parts?

  • Nope
  • Dependencies (add/update license info)
  • Modify configurations
  • The public API
  • Other affects (typed here)

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

@VGalaxies VGalaxies added the hstore Hstore backend label Jan 21, 2024
@VGalaxies VGalaxies self-assigned this Jan 21, 2024
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. bug Something isn't working tests Add or improve test cases labels Jan 21, 2024
Copy link

codecov bot commented Jan 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (pd-store@499f8e7). Click here to learn what that means.

Additional details and impacted files
@@             Coverage Diff             @@
##             pd-store    #2424   +/-   ##
===========================================
  Coverage            ?   55.15%           
  Complexity          ?     1901           
===========================================
  Files               ?      718           
  Lines               ?    58294           
  Branches            ?     7484           
===========================================
  Hits                ?    32150           
  Misses              ?    22974           
  Partials            ?     3170           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VGalaxies VGalaxies marked this pull request as draft January 22, 2024 15:17
@VGalaxies
Copy link
Contributor Author

VGalaxies commented Jan 22, 2024

@Pengzna, could you take a look at the errors related to MultiGraphsTest and EdgeCoreTest?

@Pengzna
Copy link
Contributor

Pengzna commented Jan 23, 2024

@Pengzna, could you take a look at the errors related to MultiGraphsTest and EdgeCoreTest?

Thanks your work, I'm working on it

@VGalaxies
Copy link
Contributor Author

@Pengzna, could you take a look at the errors related to MultiGraphsTest and EdgeCoreTest?

Thanks your work, I'm working on it

enhance it in next PR~

@VGalaxies VGalaxies changed the title fix(pd-store): hstore backend core tests failure (WIP) fix(pd-store): partial fix hstore backend core tests failure Jan 29, 2024
@VGalaxies VGalaxies changed the title fix(pd-store): partial fix hstore backend core tests failure fix(pd-store): partially fix hstore backend core tests failure Jan 29, 2024
@VGalaxies VGalaxies marked this pull request as ready for review January 29, 2024 14:48
@VGalaxies VGalaxies merged commit 46cb612 into pd-store Jan 29, 2024
16 of 17 checks passed
@VGalaxies VGalaxies deleted the fix-hstore-ci branch January 29, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hstore Hstore backend size:M This PR changes 30-99 lines, ignoring generated files. tests Add or improve test cases
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants