Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disable raft test in normal PR due to timeout problem #2349

Merged
merged 1 commit into from
Nov 24, 2023
Merged

chore: disable raft test in normal PR due to timeout problem #2349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,12 @@ jobs:
BASE_BRANCH_NAME: ${{ github.base_ref }}
TARGET_BRANCH_NAME: ${{ github.base_ref != '' && github.base_ref || github.ref_name }}
RELEASE_BRANCH: ${{ startsWith(github.ref_name, 'release-') || startsWith(github.ref_name, 'test-') }}
RAFT_MODE: ${{ startsWith(github.head_ref, 'test') || startsWith(github.head_ref, 'raft') }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

${{ startsWith(github.head_ref, 'raft-') || startsWith(github.head_ref, 'test-') }}

Copy link
Member Author

@imbajin imbajin Nov 13, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

${{ startsWith(github.head_ref, 'raft-') || startsWith(github.head_ref, 'test-') }}

due to “head_ref” is based on the users/dev branch name（not ours）

use “a*” mode is more common for them（also consider use contains('a*') api in future）


strategy:
fail-fast: false
matrix:
BACKEND: [ memory, cassandra, scylladb, hbase, rocksdb, mysql, postgresql ]
BACKEND: [ memory, rocksdb, hbase, cassandra, mysql, postgresql, scylladb ]
JAVA_VERSION: [ '8', '11' ]

steps:
Expand Down Expand Up @@ -77,8 +78,9 @@ jobs:
run: |
$TRAVIS_DIR/run-api-test.sh $BACKEND $REPORT_DIR

# TODO: disable raft test in normal PR due to the always timeout problem
- name: Run raft test
if: ${{ env.BACKEND == 'rocksdb' }}
if: ${{ env.RAFT_MODE == 'true' && env.BACKEND == 'rocksdb' }}
run: |
$TRAVIS_DIR/run-api-test-for-raft.sh $BACKEND $REPORT_DIR

Expand Down
8 changes: 4 additions & 4 deletions hugegraph-server/hugegraph-dist/src/assembly/static/bin/raft-tools.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@
export LANG=zh_CN.UTF-8
set -e

HOME_PATH=`dirname $0`
HOME_PATH=`cd ${HOME_PATH}/.. && pwd`
cd ${HOME_PATH}
HOME_PATH=$(dirname "$0")
HOME_PATH=$(cd "${HOME_PATH}"/.. && pwd)
cd "${HOME_PATH}"

BIN_PATH=${HOME_PATH}/bin
CONF_PATH=${HOME_PATH}/conf
Expand Down Expand Up @@ -98,7 +98,7 @@ function remove_peer() {
}

if [ "${HUGEGRAPH_URL}" = "" ]; then
HUGEGRAPH_URL=`read_property ${CONF_PATH}/rest-server.properties restserver.url`
HUGEGRAPH_URL=$(read_property ${CONF_PATH}/rest-server.properties restserver.url)
fi

if [ "${HUGEGRAPH_GRAPH}" = "" ]; then
Expand Down
4 changes: 2 additions & 2 deletions hugegraph-server/hugegraph-dist/src/assembly/travis/run-api-test-for-raft.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ BACKEND=$1
REPORT_DIR=$2
REPORT_FILE=$REPORT_DIR/jacoco-api-test.xml

TRAVIS_DIR=`dirname $0`
VERSION=`mvn help:evaluate -Dexpression=project.version -q -DforceStdout`
TRAVIS_DIR=$(dirname $0)
VERSION=$(mvn help:evaluate -Dexpression=project.version -q -DforceStdout)
SERVER_DIR=hugegraph-server/apache-hugegraph-incubating-$VERSION
RAFT1_DIR=hugegraph-raft1
RAFT2_DIR=hugegraph-raft2
Expand Down
Loading