-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: disable raft test in normal PR due to timeout problem #2349
Conversation
And replace it in pd/store module
Codecov Report
@@ Coverage Diff @@
## master #2349 +/- ##
============================================
+ Coverage 63.84% 66.38% +2.54%
- Complexity 678 981 +303
============================================
Files 507 507
Lines 42083 42083
Branches 5832 5832
============================================
+ Hits 26867 27936 +1069
+ Misses 12528 11393 -1135
- Partials 2688 2754 +66 see 50 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
@@ -20,11 +20,12 @@ jobs: | |||
BASE_BRANCH_NAME: ${{ github.base_ref }} | |||
TARGET_BRANCH_NAME: ${{ github.base_ref != '' && github.base_ref || github.ref_name }} | |||
RELEASE_BRANCH: ${{ startsWith(github.ref_name, 'release-') || startsWith(github.ref_name, 'test-') }} | |||
RAFT_MODE: ${{ startsWith(github.head_ref, 'test') || startsWith(github.head_ref, 'raft') }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
${{ startsWith(github.head_ref, 'raft-') || startsWith(github.head_ref, 'test-') }}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
${{ startsWith(github.head_ref, 'raft-') || startsWith(github.head_ref, 'test-') }}
due to “head_ref” is based on the users/dev branch name(not ours)
use “a*” mode is more common for them(also consider use contains('a*')
api in future)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…2349) And replace it in pd/store module
Purpose of the PR
Main Changes
Verifying these changes
Does this PR potentially affect the following parts?
Documentation Status
Doc - TODO
Doc - Done
Doc - No Need