Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disable raft test in normal PR due to timeout problem #2349

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

imbajin
Copy link
Member

@imbajin imbajin commented Nov 13, 2023

Purpose of the PR

  • Our rocksdb test is always timeout for a long time, and maybe won't fix it now replace it recently, the pd/store module own the feature soon
  • Keep it running in "test*" & "raft*" branch for some test / fix if we need

Main Changes

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows:
    • xxx

Does this PR potentially affect the following parts?

  • Nope
  • Dependencies (add/update license info)
  • Modify configurations
  • The public API
  • Other affects (typed here)

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

@imbajin imbajin requested review from zyxxoo and simon824 November 13, 2023 09:09
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #2349 (1dc4812) into master (a7ad7ea) will increase coverage by 2.54%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #2349      +/-   ##
============================================
+ Coverage     63.84%   66.38%   +2.54%     
- Complexity      678      981     +303     
============================================
  Files           507      507              
  Lines         42083    42083              
  Branches       5832     5832              
============================================
+ Hits          26867    27936    +1069     
+ Misses        12528    11393    -1135     
- Partials       2688     2754      +66     

see 50 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@@ -20,11 +20,12 @@ jobs:
BASE_BRANCH_NAME: ${{ github.base_ref }}
TARGET_BRANCH_NAME: ${{ github.base_ref != '' && github.base_ref || github.ref_name }}
RELEASE_BRANCH: ${{ startsWith(github.ref_name, 'release-') || startsWith(github.ref_name, 'test-') }}
RAFT_MODE: ${{ startsWith(github.head_ref, 'test') || startsWith(github.head_ref, 'raft') }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

${{ startsWith(github.head_ref, 'raft-') || startsWith(github.head_ref, 'test-') }}

Copy link
Member Author

@imbajin imbajin Nov 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

${{ startsWith(github.head_ref, 'raft-') || startsWith(github.head_ref, 'test-') }}

due to “head_ref” is based on the users/dev branch name(not ours)

use “a*” mode is more common for them(also consider use contains('a*') api in future)

Copy link
Member

@simon824 simon824 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imbajin imbajin merged commit c0ea21e into master Nov 24, 2023
21 checks passed
@imbajin imbajin deleted the diasble-raft branch November 24, 2023 11:59
VGalaxies pushed a commit to VGalaxies/incubator-hugegraph that referenced this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants