Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove stage-repo in pom due to release done & update mail rule #2128

Merged
merged 7 commits into from
Mar 16, 2023
Merged

chore: remove stage-repo in pom due to release done & update mail rule #2128

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d3bd40c
remove apache stage repo
z7658329 Feb 26, 2023
2e639d7
update notification rule
z7658329 Feb 26, 2023
7a315cb
update notification rule
z7658329 Feb 26, 2023
108fefa
Update .asf.yaml
imbajin Mar 15, 2023
31fd9c6
Update .asf.yaml
imbajin Mar 15, 2023
643524f
Update .asf.yaml
imbajin Mar 15, 2023
f45b019
Update .asf.yaml
imbajin Mar 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions .asf.yaml
View file
Open in desktop
Copy link
Member

@imbajin imbajin Mar 15, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already apply for the issues mailbox, record the info & merge this PR after issues appears in mailbox (usually <24h)

Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,13 @@ github:
require_code_owner_reviews: false
required_approving_review_count: 2

# refer https://cwiki.apache.org/confluence/display/INFRA/Git+-+.asf.yaml+features#Git.asf.yamlfeatures-Notificationsettingsforrepositories
notifications:
pullrequests_status: [email protected]
# before use the config, we should ensure the "mail" address has set well (exist)
#pullrequests_comment: [email protected]
#issues: [email protected]
#discussions: [email protected]

discussions: [email protected]
imbajin marked this conversation as resolved.
Show resolved Hide resolved
# before use the config, we should ensure the "issues" address has set well (exist)
# TODO: change to "[email protected]" after we apply it
pullrequests_comment: [email protected]
issues: [email protected]
# TODO: Send depandabot PRs to xx@ instead
# pullrequests_bot_dependabot: [email protected]
15 changes: 0 additions & 15 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -668,19 +668,4 @@
</build>
</profile>
</profiles>

<repositories>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add commit messages for why to remove it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add commit messages for why to remove it?

Update: modify it in title

<repository>
<id>staged-releases</id>
<name>staged-releases</name>
<url>https://repository.apache.org/content/groups/staging/</url>
<layout>default</layout>
<releases>
<enabled>true</enabled>
</releases>
<snapshots>
<enabled>false</enabled>
</snapshots>
</repository>
</repositories>
</project>