Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove stage-repo in pom due to release done & update mail rule #2128

Merged
merged 7 commits into from
Mar 16, 2023

Conversation

z7658329
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Feb 26, 2023

Codecov Report

Merging #2128 (f45b019) into master (614d471) will decrease coverage by 3.68%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #2128      +/-   ##
============================================
- Coverage     68.60%   64.92%   -3.68%     
+ Complexity      977      740     -237     
============================================
  Files           481      491      +10     
  Lines         39701    40221     +520     
  Branches       5580     5615      +35     
============================================
- Hits          27235    26112    -1123     
- Misses         9818    11512    +1694     
+ Partials       2648     2597      -51     

see 84 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@z7658329 z7658329 changed the title remove apache stage repo remove apache stage repo & update notification rule Feb 26, 2023
.asf.yaml Outdated
# before use the config, we should ensure the "mail" address has set well (exist)
#pullrequests_comment: [email protected]
#issues: [email protected]
#discussions: [email protected]
discussions: [email protected]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

usedev mail, we don't have issue mail now.. check the comment

@@ -668,19 +668,4 @@
</build>
</profile>
</profiles>

<repositories>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add commit messages for why to remove it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add commit messages for why to remove it?

Update: modify it in title

.asf.yaml Show resolved Hide resolved
@imbajin imbajin changed the title remove apache stage repo & update notification rule chore: remove stage-repo in pom due to release done & update mail rule Feb 26, 2023
javeme
javeme previously approved these changes Feb 27, 2023
@imbajin
Copy link
Member

imbajin commented Mar 15, 2023

@z7658329
Update: Found the dev mail still contains a lot of issues notification (which is not in expectations)

  1. maybe we need config the issue: xxx, otherwise ASF will use a default config (like send to dev)
  2. apply a new email for [email protected] or redirect it to [email protected] first

refer .asf.yaml to get the official & accurate answer, then we sync the config in all other repos

Update1: (seems we need read the doc carefully 📝)
image

Update2: (Already apply for the issues mail, and it could done by ourselves, <24h to take effect)
image

imbajin
imbajin previously approved these changes Mar 15, 2023
@imbajin imbajin requested a review from javeme March 15, 2023 11:50
imbajin
imbajin previously approved these changes Mar 15, 2023
Copy link
Member

@imbajin imbajin Mar 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already apply for the issues mailbox, record the info & merge this PR after issues appears in mailbox (usually <24h)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apache dependencies Incompatible dependencies of package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants