Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refact: improve error info of edge-update-api #1443

Merged
merged 2 commits into from
May 11, 2021
Merged

refact: improve error info of edge-update-api #1443

merged 2 commits into from
May 11, 2021

Conversation

imbajin
Copy link
Member

@imbajin imbajin commented May 7, 2021

adjust for issue #1442

javeme
javeme previously approved these changes May 7, 2021
View reviewed changes
@imbajin imbajin mentioned this pull request May 7, 2021
Closed
@javeme javeme changed the title refact: adjust the info of edge-api (update) refact: improve error info of edge-update-api May 7, 2021
@zhoney
Copy link
Contributor

zhoney commented May 8, 2021 •
edited by imbajin
Loading

CI error

[ERROR] testRemoveEdgesOfSuperVertex(com.baidu.hugegraph.core.EdgeCoreTest)  Time elapsed: 8.092 s  <<< ERROR!
java.lang.IllegalArgumentException: Already existed master 'server1' in current cluster
	at com.baidu.hugegraph.core.EdgeCoreTest.testRemoveEdgesOfSuperVertex(EdgeCoreTest.java:5511)
[ERROR] testGremlinJobAndCancel(com.baidu.hugegraph.core.TaskCoreTest)  Time elapsed: 4.268 s  <<< ERROR!
com.baidu.hugegraph.exception.NotFoundException: Can't find task with id '1875'
	at com.baidu.hugegraph.core.TaskCoreTest.setup(TaskCoreTest.java:61)
[ERROR] testGremlinJobAndRestore(com.baidu.hugegraph.core.TaskCoreTest)  Time elapsed: 0.184 s  <<< ERROR!
com.baidu.hugegraph.exception.NotFoundException: Can't find task with id '1875'
	at com.baidu.hugegraph.core.TaskCoreTest.setup(TaskCoreTest.java:61)
[ERROR] testGremlinJobWithScript(com.baidu.hugegraph.core.TaskCoreTest)  Time elapsed: 0.186 s  <<< ERROR!
com.baidu.hugegraph.exception.NotFoundException: Can't find task with id '1875'
	at com.baidu.hugegraph.core.TaskCoreTest.setup(TaskCoreTest.java:61)
[ERROR] testTask(com.baidu.hugegraph.core.TaskCoreTest)  Time elapsed: 0.186 s  <<< ERROR!
com.baidu.hugegraph.exception.NotFoundException: Can't find task with id '1875'
	at com.baidu.hugegraph.core.TaskCoreTest.setup(TaskCoreTest.java:61)
[ERROR] testGremlinJobWithError(com.baidu.hugegraph.core.TaskCoreTest)  Time elapsed: 0.187 s  <<< ERROR!
com.baidu.hugegraph.exception.NotFoundException: Can't find task with id '1875'
	at com.baidu.hugegraph.core.TaskCoreTest.setup(TaskCoreTest.java:61)
[ERROR] testTaskWithFailure(com.baidu.hugegraph.core.TaskCoreTest)  Time elapsed: 0.19 s  <<< ERROR!
com.baidu.hugegraph.exception.NotFoundException: Can't find task with id '1875'
	at com.baidu.hugegraph.core.TaskCoreTest.setup(TaskCoreTest.java:61)
[ERROR] testEphemeralJob(com.baidu.hugegraph.core.TaskCoreTest)  Time elapsed: 0.187 s  <<< ERROR!
com.baidu.hugegraph.exception.NotFoundException: Can't find task with id '1875'
	at com.baidu.hugegraph.core.TaskCoreTest.setup(TaskCoreTest.java:61)
[ERROR] testGremlinJobWithSerializedResults(com.baidu.hugegraph.core.TaskCoreTest)  Time elapsed: 0.191 s  <<< ERROR!
com.baidu.hugegraph.exception.NotFoundException: Can't find task with id '1875'
	at com.baidu.hugegraph.core.TaskCoreTest.setup(TaskCoreTest.java:61)
[ERROR] testGremlinJobWithFailure(com.baidu.hugegraph.core.TaskCoreTest)  Time elapsed: 0.191 s  <<< ERROR!
com.baidu.hugegraph.exception.NotFoundException: Can't find task with id '1875'
	at com.baidu.hugegraph.core.TaskCoreTest.setup(TaskCoreTest.java:61)
[ERROR] testGremlinJob(com.baidu.hugegraph.core.TaskCoreTest)  Time elapsed: 0.183 s  <<< ERROR!
com.baidu.hugegraph.exception.NotFoundException: Can't find task with id '1875'
	at com.baidu.hugegraph.core.TaskCoreTest.setup(TaskCoreTest.java:61)
2021-05-07 10:01:48 733518 [hugegraph-shutdown] [INFO ] com.baidu.hugegraph.HugeGraph [] - HugeGraph is shutting down
2021-05-07 10:01:48 733520 [hugegraph-shutdown] [ERROR] com.baidu.hugegraph.HugeGraph [] - Error while shutdown
java.lang.AssertionError: 2
	at com.baidu.hugegraph.task.TaskManager.shutdown(TaskManager.java:180) ~[classes/:?]
	at com.baidu.hugegraph.HugeFactory.shutdown(HugeFactory.java:140) ~[classes/:?]
	at com.baidu.hugegraph.HugeFactory.lambda$static$0(HugeFactory.java:52) ~[classes/:?]
	at java.lang.Thread.run(Thread.java:748) [?:1.8.0_252]
Exception in thread "hugegraph-shutdown" com.baidu.hugegraph.HugeException: Failed to shutdown
	at com.baidu.hugegraph.HugeFactory.shutdown(HugeFactory.java:144)
	at com.baidu.hugegraph.HugeFactory.lambda$static$0(HugeFactory.java:52)
	at java.lang.Thread.run(Thread.java:748)
Caused by: java.lang.AssertionError: 2
	at com.baidu.hugegraph.task.TaskManager.shutdown(TaskManager.java:180)
	at com.baidu.hugegraph.HugeFactory.shutdown(HugeFactory.java:140)
	... 2 more

@javeme
Copy link
Contributor

javeme commented May 8, 2021 

[ERROR] Tests run: 688, Failures: 0, Errors: 25, Skipped: 25, Time elapsed: 722.801 s <<< FAILURE! - in com.baidu.hugegraph.core.CoreTestSuite
[ERROR] testQueryEdgesByHasValues(com.baidu.hugegraph.core.EdgeCoreTest)  Time elapsed: 0.242 s  <<< ERROR!
com.baidu.hugegraph.exception.ExistedException: The edge label 'transfer' has existed
	at com.baidu.hugegraph.core.EdgeCoreTest.initSchema(EdgeCoreTest.java:144)
[ERROR] testAddEdgeWithTtlAndTtlStartTime(com.baidu.hugegraph.core.EdgeCoreTest)  Time elapsed: 0.182 s  <<< ERROR!
com.baidu.hugegraph.exception.ExistedException: The edge label 'authored' has existed
	at com.baidu.hugegraph.core.EdgeCoreTest.initSchema(EdgeCoreTest.java:150)
[ERROR] testQueryAllEdgesWithGraphAPI(com.baidu.hugegraph.core.EdgeCoreTest)  Time elapsed: 0.161 s  <<< ERROR!
com.baidu.hugegraph.exception.ExistedException: The edge label 'write' has existed
	at com.baidu.hugegraph.core.EdgeCoreTest.initSchema(EdgeCoreTest.java:155)
[ERROR] testQueryEdgesWithOrderBy(com.baidu.hugegraph.core.EdgeCoreTest)  Time elapsed: 0.169 s  <<< ERROR!
com.baidu.hugegraph.exception.ExistedException: The edge label 'look' has existed
	at com.baidu.hugegraph.core.EdgeCoreTest.initSchema(EdgeCoreTest.java:161)
[ERROR] testQueryEdgesOfVertexWithCustomizeId(com.baidu.hugegraph.core.EdgeCoreTest)  Time elapsed: 0.195 s  <<< ERROR!
com.baidu.hugegraph.exception.ExistedException: The edge label 'know' has existed
	at com.baidu.hugegraph.core.EdgeCoreTest.initSchema(EdgeCoreTest.java:165)
[ERROR] testQueryEdgeBeforeAfterUpdateMultiPropertyWithIndex(com.baidu.hugegraph.core.EdgeCoreTest)  Time elapsed: 0.243 s  <<< ERROR!
com.baidu.hugegraph.exception.ExistedException: The edge label 'followedBy' has existed
	at com.baidu.hugegraph.core.EdgeCoreTest.initSchema(EdgeCoreTest.java:169)
[ERROR] testUpdateEdgePropertyOfAggregateType(com.baidu.hugegraph.core.EdgeCoreTest)  Time elapsed: 0.222 s  <<< ERROR!
com.baidu.hugegraph.exception.ExistedException: The edge label 'friend' has existed
	at com.baidu.hugegraph.core.EdgeCoreTest.initSchema(EdgeCoreTest.java:173)
[ERROR] testAddEdgePropertyWithNotExistPropKey(com.baidu.hugegraph.core.EdgeCoreTest)  Time elapsed: 0.228 s  <<< ERROR!
com.baidu.hugegraph.exception.ExistedException: The edge label 'follow' has existed
	at com.baidu.hugegraph.core.EdgeCoreTest.initSchema(EdgeCoreTest.java:177)
[ERROR] testQueryEdgesOfVertex(com.baidu.hugegraph.core.EdgeCoreTest)  Time elapsed: 0.245 s  <<< ERROR!
com.baidu.hugegraph.exception.ExistedException: The edge label 'created' has existed
	at com.baidu.hugegraph.core.EdgeCoreTest.initSchema(EdgeCoreTest.java:181)
[ERROR] testQueryEdgeWithSecondaryIndexAndTtlInTx(com.baidu.hugegraph.core.EdgeCoreTest)  Time elapsed: 0.26 s  <<< ERROR!
com.baidu.hugegraph.exception.ExistedException: The edge label 'strike' has existed
	at com.baidu.hugegraph.core.EdgeCoreTest.initSchema(EdgeCoreTest.java:188)
[ERROR] testAddEdgePropertyWithIllegalValueForIndex(com.baidu.hugegraph.core.EdgeCoreTest)  Time elapsed: 0.852 s  <<< ERROR!
com.baidu.hugegraph.exception.ExistedException: The edge label 'read' has existed
	at com.baidu.hugegraph.core.EdgeCoreTest.initSchema(EdgeCoreTest.java:194)
[ERROR] testQueryByOutEWithDateProperty(com.baidu.hugegraph.core.EdgeCoreTest)  Time elapsed: 0.276 s  <<< ERROR!
com.baidu.hugegraph.exception.ExistedException: The edge label 'borrow' has existed
	at com.baidu.hugegraph.core.EdgeCoreTest.initSchema(EdgeCoreTest.java:201)
[ERROR] testListAccess(com.baidu.hugegraph.core.AuthTest)  Time elapsed: 0.213 s  <<< ERROR!
java.lang.IllegalArgumentException: Undefined property key: '~access_creator'
	at com.baidu.hugegraph.core.AuthTest.testListAccess(AuthTest.java:995)
[ERROR] testListBelong(com.baidu.hugegraph.core.AuthTest)  Time elapsed: 0.694 s  <<< ERROR!
java.lang.IllegalArgumentException: Undefined property key: '~belong_update'
	at com.baidu.hugegraph.core.AuthTest.testListBelong(AuthTest.java:691)
[ERROR] testUpdateAccess(com.baidu.hugegraph.core.AuthTest)  Time elapsed: 0.188 s  <<< ERROR!
java.lang.IllegalArgumentException: Undefined property key: '~access_creator'
	at com.baidu.hugegraph.core.AuthTest.testUpdateAccess(AuthTest.java:1099)
[ERROR] testUpdateBelong(com.baidu.hugegraph.core.AuthTest)  Time elapsed: 0.187 s  <<< ERROR!
java.lang.IllegalArgumentException: Undefined property key: '~belong_description'
	at com.baidu.hugegraph.core.AuthTest.testUpdateBelong(AuthTest.java:793)
[ERROR] testDeleteAccess(com.baidu.hugegraph.core.AuthTest)  Time elapsed: 0.194 s  <<< ERROR!
java.lang.IllegalArgumentException: Undefined property key: '~access_creator'
	at com.baidu.hugegraph.core.AuthTest.testDeleteAccess(AuthTest.java:1160)
[ERROR] testDeleteBelong(com.baidu.hugegraph.core.AuthTest)  Time elapsed: 0.196 s  <<< ERROR!
java.lang.IllegalArgumentException: Undefined property key: '~belong_update'
	at com.baidu.hugegraph.core.AuthTest.testDeleteBelong(AuthTest.java:833)
[ERROR] testRolePermission(com.baidu.hugegraph.core.AuthTest)  Time elapsed: 0.249 s  <<< ERROR!
java.lang.IllegalArgumentException: Undefined property key: '~belong_update'
	at com.baidu.hugegraph.core.AuthTest.testRolePermission(AuthTest.java:1220)
[ERROR] testListAllAccess(com.baidu.hugegraph.core.AuthTest)  Time elapsed: 0.207 s  <<< ERROR!
java.lang.IllegalArgumentException: Undefined property key: '~access_creator'
	at com.baidu.hugegraph.core.AuthTest.testListAllAccess(AuthTest.java:1040)
[ERROR] testListAllBelong(com.baidu.hugegraph.core.AuthTest)  Time elapsed: 0.221 s  <<< ERROR!
java.lang.IllegalArgumentException: Undefined property key: '~belong_update'
	at com.baidu.hugegraph.core.AuthTest.testListAllBelong(AuthTest.java:734)
[ERROR] testGetAccess(com.baidu.hugegraph.core.AuthTest)  Time elapsed: 0.193 s  <<< ERROR!
java.lang.IllegalArgumentException: Undefined property key: '~access_creator'
	at com.baidu.hugegraph.core.AuthTest.testGetAccess(AuthTest.java:1066)
[ERROR] testGetBelong(com.baidu.hugegraph.core.AuthTest)  Time elapsed: 0.192 s  <<< ERROR!
java.lang.IllegalArgumentException: Undefined property key: '~belong_update'
	at com.baidu.hugegraph.core.AuthTest.testGetBelong(AuthTest.java:758)
[ERROR] testCreateAccess(com.baidu.hugegraph.core.AuthTest)  Time elapsed: 0.198 s  <<< ERROR!
java.lang.IllegalArgumentException: Undefined property key: '~access_creator'
	at com.baidu.hugegraph.core.AuthTest.testCreateAccess(AuthTest.java:865)
[ERROR] testCreateBelong(com.baidu.hugegraph.core.AuthTest)  Time elapsed: 0.189 s  <<< ERROR!
java.lang.IllegalArgumentException: Undefined property key: '~belong_update'
	at com.baidu.hugegraph.core.AuthTest.testCreateBelong(AuthTest.java:611)
2021-05-08 03:59:54 723851 [hugegraph-shutdown] [INFO ] com.baidu.hugegraph.HugeGraph [] - HugeGraph is shutting down
2021-05-08 03:59:54 723859 [hugegraph-shutdown] [ERROR] com.baidu.hugegraph.HugeGraph [] - Error while shutdown
java.lang.AssertionError: 2
	at com.baidu.hugegraph.task.TaskManager.shutdown(TaskManager.java:180) ~[classes/:?]
	at com.baidu.hugegraph.HugeFactory.shutdown(HugeFactory.java:140) ~[classes/:?]
	at com.baidu.hugegraph.HugeFactory.lambda$static$0(HugeFactory.java:52) ~[classes/:?]
	at java.lang.Thread.run(Thread.java:748) [?:1.8.0_252]
Exception in thread "hugegraph-shutdown" com.baidu.hugegraph.HugeException: Failed to shutdown
	at com.baidu.hugegraph.HugeFactory.shutdown(HugeFactory.java:144)
	at com.baidu.hugegraph.HugeFactory.lambda$static$0(HugeFactory.java:52)
	at java.lang.Thread.run(Thread.java:748)
Caused by: java.lang.AssertionError: 2
	at com.baidu.hugegraph.task.TaskManager.shutdown(TaskManager.java:180)
	at com.baidu.hugegraph.HugeFactory.shutdown(HugeFactory.java:140)
	... 2 more
[INFO] 
[INFO] Results:
[INFO] 
[ERROR] Errors: 
[ERROR]   AuthTest.testCreateAccess:865 » IllegalArgument Undefined property key: '~acce...
[ERROR]   AuthTest.testCreateBelong:611 » IllegalArgument Undefined property key: '~belo...
[ERROR]   AuthTest.testDeleteAccess:1160 » IllegalArgument Undefined property key: '~acc...
[ERROR]   AuthTest.testDeleteBelong:833 » IllegalArgument Undefined property key: '~belo...
[ERROR]   AuthTest.testGetAccess:1066 » IllegalArgument Undefined property key: '~access...
[ERROR]   AuthTest.testGetBelong:758 » IllegalArgument Undefined property key: '~belong_...
[ERROR]   AuthTest.testListAccess:995 » IllegalArgument Undefined property key: '~access...
[ERROR]   AuthTest.testListAllAccess:1040 » IllegalArgument Undefined property key: '~ac...
[ERROR]   AuthTest.testListAllBelong:734 » IllegalArgument Undefined property key: '~bel...
[ERROR]   AuthTest.testListBelong:691 » IllegalArgument Undefined property key: '~belong...
[ERROR]   AuthTest.testRolePermission:1220 » IllegalArgument Undefined property key: '~b...
[ERROR]   AuthTest.testUpdateAccess:1099 » IllegalArgument Undefined property key: '~acc...
[ERROR]   AuthTest.testUpdateBelong:793 » IllegalArgument Undefined property key: '~belo...
[ERROR]   EdgeCoreTest.initSchema:194 » Existed The edge label 'read' has existed
[ERROR]   EdgeCoreTest.initSchema:177 » Existed The edge label 'follow' has existed
[ERROR]   EdgeCoreTest.initSchema:150 » Existed The edge label 'authored' has existed
[ERROR]   EdgeCoreTest.initSchema:155 » Existed The edge label 'write' has existed
[ERROR]   EdgeCoreTest.initSchema:201 » Existed The edge label 'borrow' has existed
[ERROR]   EdgeCoreTest.initSchema:169 » Existed The edge label 'followedBy' has existed
[ERROR]   EdgeCoreTest.initSchema:188 » Existed The edge label 'strike' has existed
[ERROR]   EdgeCoreTest.initSchema:144 » Existed The edge label 'transfer' has existed
[ERROR]   EdgeCoreTest.initSchema:181 » Existed The edge label 'created' has existed
[ERROR]   EdgeCoreTest.initSchema:165 » Existed The edge label 'know' has existed
[ERROR]   EdgeCoreTest.initSchema:161 » Existed The edge label 'look' has existed
[ERROR]   EdgeCoreTest.initSchema:173 » Existed The edge label 'friend' has existed
[INFO] 
[ERROR] Tests run: 688, Failures: 0, Errors: 25, Skipped: 25

@codecov
Copy link

codecov bot commented May 8, 2021

Codecov Report

Merging #1443 (e91dd0f) into master (4907886) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1443      +/-   ##
============================================
- Coverage     62.25%   62.25%   -0.01%     
  Complexity     5861     5861              
============================================
  Files           381      381              
  Lines         32139    32139              
  Branches       4504     4504              
============================================
- Hits          20009    20008       -1     
- Misses        10076    10077       +1     
  Partials       2054     2054
Impacted Files Coverage Δ Complexity Δ
...in/java/com/baidu/hugegraph/api/graph/EdgeAPI.java 54.21% <ø> (ø) 0.00 <0.00> (ø)
...du/hugegraph/backend/tx/GraphIndexTransaction.java 81.04% <0.00%> (-0.24%) 203.00% <0.00%> (-1.00%)
...c/main/java/com/baidu/hugegraph/task/HugeTask.java 69.84% <0.00%> (+0.30%) 82.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4907886...e91dd0f. Read the comment docs.

@zhoney zhoney merged commit 727b93c into master May 11, 2021
@zhoney zhoney deleted the enhance-batch-info branch May 11, 2021 09:27
zhoney pushed a commit that referenced this pull request May 27, 2021
@imbajin @zhoney
refact: improve error info of edge-update-api (#1443)
5150bb8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhoney zhoney zhoney approved these changes

@javeme javeme javeme approved these changes

@Linary Linary Linary approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@imbajin @zhoney @javeme @Linary