use NumericUtil to convert weight value (#1438)

apache · Apr 29, 2021 · 4907886 · 4907886
1 parent f49bb9d
commit 4907886
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 11 deletions.
diff --git a/...aph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/NeighborRankTraverser.java b/...aph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/NeighborRankTraverser.java
@@ -244,8 +244,8 @@ public static class Step {
         public Step(HugeGraph g, Directions direction, List<String> labels,
                     long degree, long skipDegree, int top, int capacity) {
             E.checkArgument(top > 0 && top <= MAX_TOP,
-                            "The top of each layer must be in (0, %s]",
-                            MAX_TOP);
+                            "The top of each layer must be in (0, %s], but " +
+                            "got %s", MAX_TOP, top);
             E.checkArgument(capacity > 0,
                             "The capacity of each layer must be > 0, " +
                             "but got %s", capacity);

diff --git a/.../main/java/com/baidu/hugegraph/traversal/algorithm/SingleSourceShortestPathTraverser.java b/.../main/java/com/baidu/hugegraph/traversal/algorithm/SingleSourceShortestPathTraverser.java
@@ -38,6 +38,7 @@
 import com.baidu.hugegraph.util.CollectionUtil;
 import com.baidu.hugegraph.util.E;
 import com.baidu.hugegraph.util.InsertionOrderUtil;
+import com.baidu.hugegraph.util.NumericUtil;
 import com.google.common.collect.ImmutableMap;
 import com.google.common.collect.ImmutableSet;
 
@@ -212,19 +213,12 @@ private double edgeWeight(HugeEdge edge) {
                 !edge.property(this.weight).isPresent()) {
                 edgeWeight = 1.0;
             } else {
-                edgeWeight = this.toDouble(edge.value(this.weight));
+                edgeWeight = NumericUtil.convertToNumber(
+                             edge.value(this.weight)).doubleValue();
             }
             return edgeWeight;
         }
 
-        private double toDouble(Object obj) {
-            if (obj instanceof Number) {
-                return ((Number) obj).doubleValue();
-            }
-
-            return (double) obj;
-        }
-
         private Iterator<Edge> skipSuperNodeIfNeeded(Iterator<Edge> edges) {
             if (this.skipDegree <= 0L) {
                 return edges;