This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Revert "Migrate to python3" #3478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey Nick. #3431 shows 274 file changes. This one only shows 272. |
|
I made a fresh clone, checked out a new branch and then ran 'git revert'
with the commit hash from the merge point of the old pull request. I'm not
sure why there would be a difference.
…On Wed, Mar 4, 2020, 8:53 AM Josh Fischer ***@***.***> wrote:
Hey Nick. #3431 <#3431>
shows 274 file changes. This one only shows 272.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3478?email_source=notifications&email_token=AABMNKQTUMFCOF4UW7N6YODRFZMNNA5CNFSM4LA4M2I2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENX6KUQ#issuecomment-594535762>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABMNKUWER6YGRCYPIOM3KTRFZMNNANCNFSM4LA4M2IQ>
.
|
This reverts commit 257b1a4. Conflicts: README.md
nicknezis
force-pushed
the
nicknezis/py3-revert
branch
from
bc6db82
to
c85438c
Compare
|
Updated the branch to now revert the proper commit: 257b1a4 |
|
I'm not sure why it's showing two Travis build statuses. But the most recent build looks good and the revert also looks good to me. |
joshfischer1108
approved these changes
Mar 5, 2020
sreev
pushed a commit
to sreev/incubator-heron
that referenced
this pull request
Apr 9, 2020
This reverts commit 257b1a4
Closed
nicknezis
added a commit
that referenced
this pull request
Sep 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit e9f9f5e.
This PR reverts #3431 due to issues with compilation, testing and runtime issues discovered.