This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Upgrade to Python3 for the whole repo #3431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 8, 2020 11:40
nlu90
changed the title
|
This is a follow-up PR for #3412 |
nwangtw
approved these changes
Jan 9, 2020
There was a problem hiding this comment.
I remember @kramasamy and @skanjila worked on python 3 before.
|
I noticed travis only has the python package 2.7 listed. Will this be a problem? Line 22 in ab9c205 |
@joshfischer1108 Yeah, ideally we also need to update the travis config file. I will add a new commit and see how things work. |
|
@joshfischer1108 With the Travis change, the ci job still passes |
|
@nlu90 That's fantastic. Nice work. |
|
Should the |
nicknezis
added a commit
that referenced
this pull request
Mar 4, 2020
This reverts commit 257b1a4. Conflicts: README.md
nicknezis
added a commit
that referenced
this pull request
Mar 5, 2020
sreev
pushed a commit
to sreev/incubator-heron
that referenced
this pull request
Apr 9, 2020
* migrate to python3 * update README * update travis
sreev
pushed a commit
to sreev/incubator-heron
that referenced
this pull request
Apr 9, 2020
This reverts commit 257b1a4
nicknezis
pushed a commit
that referenced
this pull request
Sep 14, 2020
* migrate to python3 * update README * update travis
nicknezis
added a commit
that referenced
this pull request
Sep 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python2 has been sunsetting: https://pythonclock.org/
We also need to upgrade from python2 to python3.