[java-info] Add basic architecture java-info into main #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acezen
reviewed
May 14, 2024
maven-projects/java-info/pom.xml
Outdated
| <relativePath>../pom.xml</relativePath> | ||
| </parent> | ||
|
|
||
| <artifactId>java-info</artifactId> |
There was a problem hiding this comment.
It's better to use info as package and directory name since spark and java reader/writer would use the module directly
There was a problem hiding this comment.
Updated, please review again.
acezen
reviewed
May 14, 2024
maven-projects/pom.xml
Outdated
| @@ -32,6 +32,7 @@ | |||
| <modules> | |||
| <module>java</module> | |||
| <module>spark</module> | |||
| <module>java-info</module> | |||
acezen
requested changes
May 14, 2024
Elssky
pushed a commit
to Elssky/incubator-graphar
that referenced
this pull request
Oct 8, 2024
* Add basic architecture java-info into main * Rename java-info to info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this PR
As we discussed in issue #478 , this PR aims to work for the first step.
What changes are included in this PR?
Basic architecture(including pom.xml and directory), yaml, type and util
Are these changes tested?
no
Are there any user-facing changes?
no