Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat][Format][Spark] Add nullable key in meta-data #365

Merged
merged 4 commits into from
Feb 23, 2024

Conversation

Thespica
Copy link
Contributor

Proposed changes

source code was done. Besides, should update test data with is_nullable declared directly.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

related issue #351

@Thespica Thespica requested a review from acezen February 18, 2024 07:43
Copy link
Contributor

@acezen acezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the implementation can parse the is_nullable from yaml file? Can you add a test to check that?

@acezen
Copy link
Contributor

acezen commented Feb 23, 2024

hi john,the #369 has been merged, you can rebase the main.

@Thespica Thespica force-pushed the gar-nullable-key-spark branch from 4412ae3 to 07ad518 Compare February 23, 2024 05:22
Copy link
Contributor

@acezen acezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acezen acezen merged commit a0fdabe into apache:main Feb 23, 2024
4 checks passed
@Thespica Thespica deleted the gar-nullable-key-spark branch March 18, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants