Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat][Format] Support nullable key-value in property metadata #351

Closed
acezen opened this issue Jan 30, 2024 · 6 comments
Closed

[Feat][Format] Support nullable key-value in property metadata #351

acezen opened this issue Jan 30, 2024 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@acezen
Copy link
Contributor

acezen commented Jan 30, 2024

Is your feature request related to a problem? Please describe.
Some graph database(like HugeGraph) that they have a metadata of property that show the property can have null value or not. GraphAr should support the metadata.

Describe the solution you'd like
Add a key call nullable to Property struct and provide related API.
like is_primary

Describe alternatives you've considered
no alternatives

Additional context
related discussion #343

@acezen acezen added the enhancement New feature or request label Jan 30, 2024
@Thespica Thespica self-assigned this Jan 30, 2024
@Thespica
Copy link
Contributor

Should the new field be alternative when parsing?

If it is required, we have to change all data, and loss compatibility backwards.

@acezen
Copy link
Contributor Author

acezen commented Jan 30, 2024

Should the new field be alternative when parsing?

If it is required, we have to change all data, and loss compatibility backwards.

yes, I think it can be optional in info yaml that if the property don't contain nullable key, it's false by default.

@acezen
Copy link
Contributor Author

acezen commented Feb 4, 2024

hi, @Thespica , since the C++ library has support the feature, can you help to support the nullable key-value for GraphAr-Spark library too.

@SemyonSinchenko
Copy link
Member

SemyonSinchenko commented Feb 7, 2024

@acezen May we wait with it a little? Cause I'm making a huge refactoring of graphar-spark (#320, #361) and merging will be pain

@acezen
Copy link
Contributor Author

acezen commented Feb 7, 2024

@acezen May we wait with it a little? Cause I'm making a huge refactoring of graphar-spark (#320, #361) and merging will be pain

yes, this issue can wait until the refactor merged

@acezen
Copy link
Contributor Author

acezen commented Feb 26, 2024

closed as the issue has been resolved.

@acezen acezen closed this as completed Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants