Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-6784][GLUTEN-6828][VL] Add tests for weekOfYear and cast string as date #6888

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

zml1206
Copy link
Contributor

@zml1206 zml1206 commented Aug 16, 2024

What changes were proposed in this pull request?

Add test after resolved #6784 and #6828.

How was this patch tested?

@github-actions github-actions bot added the VELOX label Aug 16, 2024
Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@zhouyuan zhouyuan changed the title [VL] Add test for weekOfYear and cast string to date [GLUTEN-6828][VL] Add test for weekOfYear and cast string to date Aug 16, 2024
Copy link

#6828

@zml1206 zml1206 marked this pull request as draft September 4, 2024 03:48
@zml1206
Copy link
Contributor Author

zml1206 commented Oct 3, 2024

@FelixYBW Thank you.

Copy link
Contributor

@rui-mo rui-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rui-mo rui-mo changed the title [GLUTEN-6828][VL] Add test for weekOfYear and cast string to date [GLUTEN-6828][GLUTEN-6784][VL] Add tests for weekOfYear and cast string as date Oct 10, 2024
@rui-mo rui-mo changed the title [GLUTEN-6828][GLUTEN-6784][VL] Add tests for weekOfYear and cast string as date [GLUTEN-6784][GLUTEN-6828][VL] Add tests for weekOfYear and cast string as date Oct 10, 2024
Copy link

#6784

@rui-mo rui-mo merged commit 5a1f6f2 into apache:main Oct 10, 2024
44 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCDS SF2000 with Velox backend, for reference only ====

query log/native_master_10_10_2024_time.csv log/native_master_10_09_2024_a6c0798b03_time.csv difference percentage
q1 14.50 13.73 -0.767 94.71%
q2 15.35 15.31 -0.043 99.72%
q3 5.32 5.28 -0.039 99.26%
q4 72.11 70.86 -1.257 98.26%
q5 8.92 9.80 0.876 109.81%
q6 2.27 2.38 0.110 104.84%
q7 8.09 8.94 0.853 110.54%
q8 5.50 3.56 -1.944 64.68%
q9 26.68 26.96 0.276 101.04%
q10 9.21 8.78 -0.424 95.39%
q11 36.77 37.08 0.311 100.85%
q12 1.40 1.53 0.132 109.40%
q13 7.56 6.24 -1.326 82.46%
q14a 49.14 48.84 -0.300 99.39%
q14b 43.66 42.52 -1.136 97.40%
q15 2.43 2.43 -0.004 99.85%
q16 50.70 50.33 -0.368 99.27%
q17 4.89 6.03 1.135 123.19%
q18 6.96 7.04 0.083 101.19%
q19 2.03 2.18 0.151 107.46%
q20 1.40 1.37 -0.029 97.95%
q21 1.13 1.10 -0.027 97.61%
q22 8.04 7.86 -0.181 97.75%
q23a 107.97 107.53 -0.447 99.59%
q23b 130.06 128.45 -1.610 98.76%
q24a 109.79 111.72 1.931 101.76%
q24b 101.57 108.39 6.826 106.72%
q25 4.13 5.90 1.766 142.74%
q26 3.55 4.47 0.922 125.99%
q27 4.38 4.66 0.286 106.53%
q28 32.26 33.19 0.935 102.90%
q29 10.64 9.33 -1.308 87.71%
q30 4.69 4.75 0.066 101.42%
q31 6.77 6.99 0.216 103.19%
q32 1.30 1.20 -0.096 92.62%
q33 4.47 4.43 -0.049 98.90%
q34 4.00 3.88 -0.118 97.05%
q35 9.62 7.92 -1.697 82.36%
q36 6.44 5.86 -0.582 90.97%
q37 4.91 5.22 0.314 106.40%
q38 15.72 13.58 -2.138 86.40%
q39a 3.31 3.12 -0.196 94.09%
q39b 3.19 3.00 -0.189 94.07%
q40 4.12 3.99 -0.124 96.98%
q41 0.63 0.76 0.134 121.25%
q42 1.02 1.03 0.016 101.53%
q43 4.75 4.83 0.078 101.63%
q44 9.37 8.46 -0.906 90.33%
q45 3.24 3.34 0.102 103.15%
q46 4.51 3.92 -0.585 87.02%
q47 18.44 17.63 -0.807 95.62%
q48 5.16 5.15 -0.009 99.82%
q49 6.75 6.66 -0.091 98.66%
q50 21.35 21.38 0.029 100.14%
q51 9.56 9.87 0.309 103.23%
q52 1.03 1.12 0.093 109.11%
q53 2.43 2.42 -0.011 99.55%
q54 3.82 3.83 0.013 100.35%
q55 0.98 1.01 0.029 102.97%
q56 3.98 4.11 0.133 103.34%
q57 10.58 10.51 -0.070 99.34%
q58 2.60 2.47 -0.132 94.94%
q59 11.41 10.67 -0.742 93.50%
q60 4.05 4.13 0.089 102.20%
q61 4.12 4.04 -0.087 97.90%
q62 4.34 4.34 -0.007 99.84%
q63 2.46 2.42 -0.041 98.33%
q64 61.99 60.93 -1.060 98.29%
q65 18.42 17.11 -1.319 92.84%
q66 4.57 4.74 0.170 103.72%
q67 440.78 421.15 -19.627 95.55%
q68 3.75 3.91 0.158 104.22%
q69 5.09 7.84 2.751 154.08%
q70 13.26 10.50 -2.765 79.15%
q71 2.33 2.51 0.175 107.51%
q72 216.90 213.79 -3.110 98.57%
q73 2.19 2.22 0.032 101.46%
q74 22.88 23.75 0.875 103.83%
q75 27.56 26.97 -0.588 97.87%
q76 12.86 14.08 1.222 109.50%
q77 2.13 2.11 -0.019 99.09%
q78 49.30 49.56 0.259 100.52%
q79 4.07 4.15 0.082 102.02%
q80 11.26 12.07 0.804 107.14%
q81 4.49 4.80 0.314 106.99%
q82 6.62 7.13 0.504 107.61%
q83 1.63 1.60 -0.033 97.96%
q84 2.79 2.78 -0.003 99.88%
q85 7.96 6.97 -0.992 87.54%
q86 4.28 4.23 -0.052 98.78%
q87 15.42 14.15 -1.271 91.75%
q88 18.15 18.61 0.460 102.53%
q89 3.06 3.36 0.298 109.73%
q90 2.81 2.89 0.078 102.77%
q91 2.31 2.31 -0.008 99.64%
q92 1.39 1.27 -0.113 91.82%
q93 41.18 42.33 1.154 102.80%
q94 26.43 27.81 1.379 105.22%
q9 90.09 92.04 1.952 102.17%
q5 2.55 3.76 1.210 147.42%
q96 17.96 18.59 0.631 103.52%
q97 1.89 1.95 0.068 103.60%
q98 11.74 11.61 -0.133 98.86%
q99 11.74 11.61 -0.133 98.86%
total 2255.59 2237.40 -18.194 99.19%

@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_master_10_10_2024_time.csv log/native_master_10_09_2024_a6c0798b03_time.csv difference percentage
q1 52.85 52.52 -0.329 99.38%
q2 31.06 31.51 0.448 101.44%
q3 53.93 55.04 1.109 102.06%
q4 43.82 41.96 -1.856 95.76%
q5 106.35 105.57 -0.778 99.27%
q6 11.63 12.96 1.327 111.41%
q7 110.84 111.45 0.614 100.55%
q8 117.39 115.75 -1.638 98.60%
q9 171.83 171.61 -0.222 99.87%
q10 67.92 67.91 -0.008 99.99%
q11 27.12 26.82 -0.302 98.89%
q12 32.37 32.88 0.516 101.59%
q13 51.89 53.23 1.338 102.58%
q14 22.13 25.82 3.696 116.70%
q15 50.83 52.01 1.182 102.33%
q16 17.78 18.20 0.426 102.40%
q17 126.30 127.79 1.488 101.18%
q18 198.41 201.02 2.602 101.31%
q19 30.33 26.84 -3.483 88.52%
q20 42.76 42.04 -0.715 98.33%
q21 334.03 336.29 2.264 100.68%
q22 16.28 17.07 0.790 104.85%
total 1717.84 1726.31 8.471 100.49%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Result mismatch of weekOfYear
3 participants