Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Result mismatch of weekOfYear #6784

Closed
zml1206 opened this issue Aug 12, 2024 · 3 comments · Fixed by #6888
Closed

Result mismatch of weekOfYear #6784

zml1206 opened this issue Aug 12, 2024 · 3 comments · Fixed by #6888
Labels
bug Something isn't working triage

Comments

@zml1206
Copy link
Contributor

zml1206 commented Aug 12, 2024

Backend

VL (Velox)

Bug description

select d,weekofyear(d) from values ('2021-12-31'),('2022-01-01') as data(d)

spark:

+----------+-------------+
|         d|weekofyear(d)|
+----------+-------------+
|2021-12-31|           52|
|2022-01-01|           52|

gluten:

+----------+-------------+
|         d|weekofyear(d)|
+----------+-------------+
|2021-12-31|           52|
|2022-01-01|           53|

Spark version

None

Spark configurations

No response

System information

No response

Relevant logs

No response

@zml1206 zml1206 added bug Something isn't working triage labels Aug 12, 2024
@zhli1142015
Copy link
Contributor

Looks this issue is already fixed for Presto but not Spark.
facebookincubator/velox@f8f538e

@PHILO-HE
Copy link
Contributor

@zml1206, could you fix this issue in Velox? In the initial implementation, the only difference between spark and presto is the return type. See facebookincubator/velox#5941. Now we may just need to copy presto's fix for spark.

@zml1206
Copy link
Contributor Author

zml1206 commented Aug 13, 2024

@zml1206, could you fix this issue in Velox? In the initial implementation, the only difference between spark and presto is the return type. See facebookincubator/velox#5941. Now we may just need to copy presto's fix for spark.

Processing in facebookincubator/velox#10713.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage
Projects
None yet
3 participants