-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] fix clickhouse monitor #2874
Conversation
A bit confused🐶🐶, why change the ping_available -> summary then it works |
Looks like it is caused by #2266 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is better to change code in HttpCollectImpl
Agree, metrics are not recommended to be hardcoded in code |
hi, #2266 In order for http protocol collection to support obtaining data from response headers, should we add a parsing type as |
Yes, it is better than hard code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What's changed?
Checklist
Add or update API