Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] fix clickhouse monitor #2874

Merged
merged 5 commits into from
Dec 17, 2024
Merged

[Fix] fix clickhouse monitor #2874

merged 5 commits into from
Dec 17, 2024

Conversation

LiuTianyou
Copy link
Contributor

What's changed?

  1. Fix the problem that clickhouse monitoring cannot be used normally [Question] <title>连接ClichHouse集群Collect Timeout No Response #2872

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@Calvin979 Calvin979 linked an issue Dec 12, 2024 that may be closed by this pull request
@tomsun28 tomsun28 added this to the 1.6.2 milestone Dec 12, 2024
@tomsun28
Copy link
Contributor

A bit confused🐶🐶, why change the ping_available -> summary then it works

@Calvin979
Copy link
Contributor

A bit confused🐶🐶, why change the ping_available -> summary then it works

Looks like it is caused by #2266

Copy link
Contributor

@Calvin979 Calvin979 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is better to change code in HttpCollectImpl

@tomsun28
Copy link
Contributor

I think it is better to change code in HttpCollectImpl

Agree, metrics are not recommended to be hardcoded in code

yuluo-yx
yuluo-yx previously approved these changes Dec 14, 2024
@LiuTianyou
Copy link
Contributor Author

I think it is better to change code in HttpCollectImpl

hi, #2266 In order for http protocol collection to support obtaining data from response headers, should we add a parsing type as response_header and obtain the header data corresponding to the metrics name?

@Calvin979
Copy link
Contributor

I think it is better to change code in HttpCollectImpl

hi, #2266 In order for http protocol collection to support obtaining data from response headers, should we add a parsing type as response_header and obtain the header data corresponding to the metrics name?

Yes, it is better than hard code

Copy link
Contributor

@Calvin979 Calvin979 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LiuTianyou LiuTianyou merged commit d4f6fc1 into apache:master Dec 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

[Question] <title>连接ClichHouse集群Collect Timeout No Response
5 participants