HBASE-23210 Backport HBASE-15519 (Add per-user metrics) to branch-1 #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New unit tests pass |
|
@joshelser I couldn't ask @ankitsinghal for a review for some reason, but i see you recently reviewed similar |
apurtell
force-pushed
the
HBASE-23210-branch-1
branch
from
b770177 to
b31f442
Compare
joshelser
approved these changes
Oct 24, 2019
| class SweepRunnable implements Runnable { | ||
| @Override public void run() { | ||
| if (LOG.isTraceEnabled()) { | ||
| LOG.trace("Starting sweep of lossyCounting-" + name); |
There was a problem hiding this comment.
nit, could use the {} markers and drop the isTraceEnabled()
There was a problem hiding this comment.
This came in from branch-2 change. I agree but try not to second guess the original contributor on backports.
joshelser
reviewed
Oct 24, 2019
| try { | ||
| sweep(); | ||
| } catch (Exception exception) { | ||
| LOG.debug("Error while sweeping of lossyCounting-{}", name, exception); |
There was a problem hiding this comment.
(damnit, lost the previous comment)
Make sure you're getting the right debug method here. The debug(String, Object, Exception) not debug(String, Object, Object). Hit this the other day.
apurtell
force-pushed
the
HBASE-23210-branch-1
branch
from
b31f442 to
ba2d5ff
Compare
|
💔 -1 overall
This message was automatically generated. |
|
Back soon to fix checkstyle issues |
apurtell
force-pushed
the
HBASE-23210-branch-1
branch
from
ba2d5ff to
dc96c24
Compare
|
Fixed some checkstyle nits, will merge tomorrow |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
HBASE-15519 Add per-user metrics with lossy counting Introducing property hbase.regionserver.user.metrics.enabled(Default:true) to disable user metrics in case it accounts for any performance issues
apurtell
force-pushed
the
HBASE-23210-branch-1
branch
from
dc96c24 to
5127c2e
Compare
|
Fixed the other checkstyle indent nit |
lhofhansl
reviewed
Dec 5, 2019
| this.bucketSize = (long) Math.ceil(1 / errorRate); | ||
| this.currentTerm = 1; | ||
| this.totalDataCount = 0; | ||
| this.data = new ConcurrentHashMap<>(); | ||
| this.listener = listener; | ||
| calculateCurrentTerm(); | ||
| executor = Executors.newSingleThreadExecutor(); |
There was a problem hiding this comment.
I think this causes the RegionServer process to hang upon shutdown since we're not using daemon threads.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HBASE-15519 Add per-user metrics with lossy counting
Introducing property hbase.regionserver.user.metrics.enabled(Default:true)
to disable user metrics in case it accounts for any performance issues