HBASE-23149 RatioBasedCompactionPolicy#shouldPerformMajorCompaction l…

…ogic is not correct (#744) Signed-off-by: Guangxu Cheng <[email protected]>
apache · Oct 24, 2019 · 41f6713 · 41f6713
1 parent f0999a1
commit 41f6713
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/...ain/java/org/apache/hadoop/hbase/regionserver/compactions/RatioBasedCompactionPolicy.java b/...ain/java/org/apache/hadoop/hbase/regionserver/compactions/RatioBasedCompactionPolicy.java
@@ -105,8 +105,8 @@ public boolean shouldPerformMajorCompaction(final Collection<StoreFile> filesToC
       } else {
         LOG.debug("Major compaction triggered on store " + regionInfo
           + "; time since last major compaction " + (now - lowTimestamp) + "ms");
+        result = true;
       }
-      result = true;
     }
     return result;
   }

diff --git a/...rc/main/java/org/apache/hadoop/hbase/regionserver/compactions/SortedCompactionPolicy.java b/...rc/main/java/org/apache/hadoop/hbase/regionserver/compactions/SortedCompactionPolicy.java
@@ -120,7 +120,7 @@ public abstract boolean shouldPerformMajorCompaction(final Collection<StoreFile>
    * @return When to run next major compaction
    */
   public long getNextMajorCompactTime(final Collection<StoreFile> filesToCompact) {
-    // default = 24hrs
+    // default = 7days
     long ret = comConf.getMajorCompactionPeriod();
     if (ret > 0) {
       // default = 20% = +/- 4.8 hrs