Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBASE-28353 Close HBase connection on implicit exit from HBase shell #5673

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

stoty
Copy link
Contributor

@stoty stoty commented Feb 9, 2024

No description provided.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 44s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 💚 mvninstall 3m 51s master passed
+1 💚 spotless 0m 56s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚 mvninstall 3m 39s the patch passed
-0 ⚠️ rubocop 0m 5s The patch generated 3 new + 31 unchanged - 2 fixed = 34 total (was 33)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 spotless 0m 50s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 11s The patch does not generate ASF License warnings.
11m 42s
Subsystem Report/Notes
Docker ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5673/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #5673
Optional Tests dupname asflicense javac spotless rubocop
uname Linux ecd4deb35f9d 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 98eb3e0
Default Java Eclipse Adoptium-11.0.17+8
rubocop https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5673/1/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count 72 (vs. ulimit of 30000)
modules C: hbase-shell U: hbase-shell
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5673/1/console
versions git=2.34.1 maven=3.8.6 rubocop=1.37.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 39s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 3m 12s master passed
+1 💚 javadoc 0m 12s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 2m 44s the patch passed
+1 💚 javadoc 0m 11s the patch passed
_ Other Tests _
+1 💚 unit 7m 21s hbase-shell in the patch passed.
15m 1s
Subsystem Report/Notes
Docker ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5673/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #5673
Optional Tests javac javadoc unit
uname Linux 633dfba2f517 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 98eb3e0
Default Java Temurin-1.8.0_352-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5673/1/testReport/
Max. process+thread count 1983 (vs. ulimit of 30000)
modules C: hbase-shell U: hbase-shell
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5673/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 25s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 3m 22s master passed
+1 💚 javadoc 0m 10s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 2m 56s the patch passed
+1 💚 javadoc 0m 8s the patch passed
_ Other Tests _
+1 💚 unit 7m 42s hbase-shell in the patch passed.
15m 38s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5673/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #5673
Optional Tests javac javadoc unit
uname Linux 336b4c4e0092 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 98eb3e0
Default Java Eclipse Adoptium-11.0.17+8
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5673/1/testReport/
Max. process+thread count 2010 (vs. ulimit of 30000)
modules C: hbase-shell U: hbase-shell
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5673/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@bbeaudreault bbeaudreault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a ruby expert, but this makes sense based on my reading of at_exit

@meszibalu meszibalu merged commit 9656006 into apache:master Feb 13, 2024
1 check passed
asfgit pushed a commit that referenced this pull request Feb 13, 2024
asfgit pushed a commit that referenced this pull request Feb 13, 2024
asfgit pushed a commit that referenced this pull request Feb 13, 2024
asfgit pushed a commit that referenced this pull request Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants