HBASE-28353 Close HBase connection on implicit exit from HBase shell (#…

…5673) Signed-off-by: Bryan Beaudreault <[email protected]> Signed-off-by: Balazs Meszaros <[email protected]>
apache · Feb 13, 2024 · 9656006 · 9656006
1 parent a4002d6
commit 9656006
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/hbase-shell/src/main/ruby/shell.rb b/hbase-shell/src/main/ruby/shell.rb
@@ -108,11 +108,6 @@ class Shell
     # exit the interactive shell and save that this
     # happend via a call to exit
     def exit(ret = 0)
-      # Non-deamon Netty threadpool in ZK ClientCnxnSocketNetty cannot be shut down otherwise
-      begin
-        hbase.shutdown
-      rescue Exception
-      end
       @exit_code = ret
       IRB.irb_exit(IRB.CurrentContext.irb, ret)
     end
@@ -323,6 +318,13 @@ def get_workspace
       hbase_receiver.send :define_singleton_method, :exit, lambda { |rc = 0|
         @shell.exit(rc)
       }
+      at_exit do
+        # Non-deamon Netty threadpool in ZK ClientCnxnSocketNetty cannot be shut down otherwise
+        begin
+          hbase.shutdown
+        rescue Exception
+        end
+      end
       ::IRB::WorkSpace.new(hbase_receiver.get_binding)
     end