Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-27791 Upgrade vega and its related js libraries #5173

Merged
merged 1 commit into from
Apr 17, 2023
Merged

HBASE-27791 Upgrade vega and its related js libraries #5173

merged 1 commit into from
Apr 17, 2023

Conversation

NihalJain
Copy link
Contributor

No description provided.

@NihalJain
Copy link
Contributor Author

NihalJain commented Apr 12, 2023 •
edited
Loading

Built HBase assembly tarball locally. Started HBase in hbase.cluster.distributed=false mode. Ran PE tool on 2 tables with 100K rows. Opened Master web UI and verified the visualisations are as expected.
Screenshot 2023-04-12 at 5 47 05 PM

NOTE: Above image is edited to hide IP with thick line

Also clicked on the various options available for the visualisation, like save SVG, PNG etc. and ensured all the 5 options work as expected.

Also verified http://localhost:16010/static/js/ has expected JS files:
Screenshot 2023-04-12 at 5 46 51 PM

The attached JS files are downloaded from below CDN:

FYI @ndimiduk, please review!

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 27s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 jshint 0m 0s jshint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for branch
+1 💚 mvninstall 3m 31s master passed
+1 💚 spotless 0m 40s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 10s Maven dependency ordering for patch
+1 💚 mvninstall 3m 10s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 spotless 0m 36s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 17s The patch does not generate ASF License warnings.
10m 35s
Subsystem Report/Notes
Docker ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5173/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #5173
Optional Tests dupname asflicense javac spotless jshint
uname Linux fc6db542b2d6 5.4.0-1094-aws #102~18.04.1-Ubuntu SMP Tue Jan 10 21:07:03 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / e4b4cef
Default Java Eclipse Adoptium-11.0.17+8
Max. process+thread count 86 (vs. ulimit of 30000)
modules C: hbase-server . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5173/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 27s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 17s Maven dependency ordering for branch
+1 💚 mvninstall 5m 5s master passed
+1 💚 javadoc 2m 43s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 8s Maven dependency ordering for patch
+1 💚 mvninstall 3m 52s the patch passed
+1 💚 javadoc 3m 14s the patch passed
_ Other Tests _
-1 ❌ unit 290m 29s root in the patch failed.
312m 12s
Subsystem Report/Notes
Docker ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5173/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #5173
Optional Tests javac javadoc unit
uname Linux bc19aa43f191 5.4.0-1093-aws #102~18.04.2-Ubuntu SMP Wed Dec 7 00:31:59 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / e4b4cef
Default Java Eclipse Adoptium-11.0.17+8
unit https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5173/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5173/1/testReport/
Max. process+thread count 2724 (vs. ulimit of 30000)
modules C: hbase-server . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5173/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 25s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for branch
+1 💚 mvninstall 3m 2s master passed
+1 💚 javadoc 1m 42s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 10s Maven dependency ordering for patch
+1 💚 mvninstall 2m 45s the patch passed
+1 💚 javadoc 1m 40s the patch passed
_ Other Tests _
+1 💚 unit 388m 46s root in the patch passed.
404m 58s
Subsystem Report/Notes
Docker ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5173/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #5173
Optional Tests javac javadoc unit
uname Linux ff8e9545264a 5.4.0-1097-aws #105~18.04.1-Ubuntu SMP Mon Feb 13 17:50:57 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / e4b4cef
Default Java Temurin-1.8.0_352-b08
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5173/1/testReport/
Max. process+thread count 4805 (vs. ulimit of 30000)
modules C: hbase-server . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5173/1/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

chrajeshbabu
chrajeshbabu approved these changes Apr 13, 2023
View reviewed changes
Copy link
Contributor

@chrajeshbabu chrajeshbabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

ndimiduk
ndimiduk approved these changes Apr 17, 2023
View reviewed changes
Copy link
Member

@ndimiduk ndimiduk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @NihalJain .

One follow-up question: do you have a suggestion as to how HBase build could pull in these javascript dependencies automatically? I think it would be better for everyone if these were not managed by hand.

@ndimiduk ndimiduk merged commit 24c471a into apache:master Apr 17, 2023
ndimiduk pushed a commit to ndimiduk/hbase that referenced this pull request Apr 17, 2023
@NihalJain @ndimiduk
HBASE-27791 Upgrade vega and its related js libraries (apache#5173)
4599830 
Signed-off-by: Rajeshbabu Chintaguntla <[email protected]>
Signed-off-by: Nick Dimiduk <[email protected]>
ndimiduk pushed a commit to ndimiduk/hbase that referenced this pull request Apr 17, 2023
@NihalJain @ndimiduk
HBASE-27791 Upgrade vega and its related js libraries (apache#5173)
f6e9543 
Signed-off-by: Rajeshbabu Chintaguntla <[email protected]>
Signed-off-by: Nick Dimiduk <[email protected]>
ndimiduk pushed a commit that referenced this pull request Apr 18, 2023
@NihalJain @ndimiduk
HBASE-27791 Upgrade vega and its related js libraries (#5173)
f6900f8 
Signed-off-by: Rajeshbabu Chintaguntla <[email protected]>
Signed-off-by: Nick Dimiduk <[email protected]>
ndimiduk pushed a commit that referenced this pull request Apr 18, 2023
@NihalJain @ndimiduk
HBASE-27791 Upgrade vega and its related js libraries (#5173)
4ee389a 
Signed-off-by: Rajeshbabu Chintaguntla <[email protected]>
Signed-off-by: Nick Dimiduk <[email protected]>
@NihalJain
Copy link
Contributor Author

NihalJain commented Apr 18, 2023 •
edited
Loading

Looks good to me @NihalJain .

One follow-up question: do you have a suggestion as to how HBase build could pull in these javascript dependencies automatically? I think it would be better for everyone if these were not managed by hand.

Created https://issues.apache.org/jira/browse/HBASE-27802 to discuss same

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrajeshbabu chrajeshbabu chrajeshbabu approved these changes

@ndimiduk ndimiduk ndimiduk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NihalJain @Apache-HBase @ndimiduk @chrajeshbabu