Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBASE-26717 [hbase-thirdparty] hbase-shaded-jersey packages unshaded classes #4091

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

apurtell
Copy link
Contributor

@apurtell apurtell commented Feb 2, 2022

This is the hbase-http module side changes.
For hbase-thirdparty changes, see apache/hbase-thirdparty#73

@apurtell apurtell requested review from busbey and Apache9 February 2, 2022 01:36
@apurtell
Copy link
Contributor Author

apurtell commented Feb 2, 2022

Update fixes assembly failures (LICENSE.vm update). We mention the EDL 1.0 (it's in category A) elsewhere but it's missing from non_aggregate_fine.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 26s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 27s Maven dependency ordering for branch
+1 💚 mvninstall 4m 21s master passed
+1 💚 compile 9m 44s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 23s Maven dependency ordering for patch
-1 ❌ mvninstall 3m 58s root in the patch failed.
-1 ❌ compile 9m 36s root in the patch failed.
-0 ⚠️ javac 9m 36s root in the patch failed.
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 7s The patch has no ill-formed XML file.
-1 ❌ hadoopcheck 5m 16s The patch causes 10 errors with Hadoop v3.1.2.
-1 ❌ hadoopcheck 10m 34s The patch causes 10 errors with Hadoop v3.2.2.
-1 ❌ hadoopcheck 16m 5s The patch causes 10 errors with Hadoop v3.3.1.
_ Other Tests _
+1 💚 asflicense 1m 10s The patch does not generate ASF License warnings.
48m 32s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4091/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #4091
Optional Tests dupname asflicense javac hadoopcheck xml compile
uname Linux 61559e1b35eb 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 3da23c2
Default Java AdoptOpenJDK-1.8.0_282-b08
mvninstall https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4091/1/artifact/yetus-general-check/output/patch-mvninstall-root.txt
compile https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4091/1/artifact/yetus-general-check/output/patch-compile-root.txt
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4091/1/artifact/yetus-general-check/output/patch-compile-root.txt
hadoopcheck https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4091/1/artifact/yetus-general-check/output/patch-javac-3.1.2.txt
hadoopcheck https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4091/1/artifact/yetus-general-check/output/patch-javac-3.2.2.txt
hadoopcheck https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4091/1/artifact/yetus-general-check/output/patch-javac-3.3.1.txt
Max. process+thread count 141 (vs. ulimit of 30000)
modules C: hbase-http hbase-shaded hbase-shaded/hbase-shaded-client hbase-shaded/hbase-shaded-testing-util . U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4091/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 4s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 25s Maven dependency ordering for branch
+1 💚 mvninstall 4m 46s master passed
+1 💚 compile 3m 16s master passed
+1 💚 shadedjars 8m 29s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 3m 56s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 22s Maven dependency ordering for patch
-1 ❌ mvninstall 3m 37s root in the patch failed.
-1 ❌ compile 2m 45s root in the patch failed.
-0 ⚠️ javac 2m 45s root in the patch failed.
-1 ❌ shadedjars 7m 44s patch has 10 errors when building our shaded downstream artifacts.
+1 💚 javadoc 3m 53s the patch passed
_ Other Tests _
-1 ❌ unit 163m 49s root in the patch failed.
207m 5s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4091/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #4091
Optional Tests javac javadoc unit shadedjars compile
uname Linux d28667a1f3a4 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 3da23c2
Default Java AdoptOpenJDK-11.0.10+9
mvninstall https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4091/1/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt
compile https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4091/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-root.txt
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4091/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-root.txt
shadedjars https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4091/1/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4091/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4091/1/testReport/
Max. process+thread count 3843 (vs. ulimit of 30000)
modules C: hbase-http hbase-shaded hbase-shaded/hbase-shaded-client hbase-shaded/hbase-shaded-testing-util . U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4091/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache9
Copy link
Contributor

Apache9 commented Feb 2, 2022

Let's use another jira issue to commit this change?

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 27s Docker mode activated.
-0 ⚠️ yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 25s Maven dependency ordering for branch
+1 💚 mvninstall 4m 6s master passed
+1 💚 compile 2m 47s master passed
+1 💚 shadedjars 8m 22s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 3m 7s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 22s Maven dependency ordering for patch
-1 ❌ mvninstall 3m 49s root in the patch failed.
-1 ❌ compile 2m 48s root in the patch failed.
-0 ⚠️ javac 2m 48s root in the patch failed.
+1 💚 shadedjars 8m 18s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 3m 12s the patch passed
_ Other Tests _
-1 ❌ unit 374m 32s root in the patch failed.
415m 44s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4091/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #4091
Optional Tests javac javadoc unit shadedjars compile
uname Linux 821c697dbf44 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 3da23c2
Default Java AdoptOpenJDK-1.8.0_282-b08
mvninstall https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4091/1/artifact/yetus-jdk8-hadoop3-check/output/patch-mvninstall-root.txt
compile https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4091/1/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-root.txt
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4091/1/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-root.txt
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4091/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4091/1/testReport/
Max. process+thread count 5217 (vs. ulimit of 30000)
modules C: hbase-http hbase-shaded hbase-shaded/hbase-shaded-client hbase-shaded/hbase-shaded-testing-util . U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4091/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 4m 6s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 26s Maven dependency ordering for branch
+1 💚 mvninstall 4m 9s master passed
+1 💚 compile 9m 2s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 22s Maven dependency ordering for patch
+1 💚 mvninstall 3m 52s the patch passed
+1 💚 compile 8m 58s the patch passed
+1 💚 javac 8m 58s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 7s The patch has no ill-formed XML file.
+1 💚 hadoopcheck 19m 35s Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1.
_ Other Tests _
+1 💚 asflicense 1m 22s The patch does not generate ASF License warnings.
60m 27s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4091/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #4091
Optional Tests dupname asflicense javac hadoopcheck xml compile
uname Linux c3d22220521b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 3da23c2
Default Java AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count 141 (vs. ulimit of 30000)
modules C: hbase-resource-bundle hbase-http hbase-shaded hbase-shaded/hbase-shaded-client hbase-shaded/hbase-shaded-testing-util . U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4091/2/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 4m 47s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 28s Maven dependency ordering for branch
+1 💚 mvninstall 5m 56s master passed
+1 💚 compile 3m 58s master passed
+1 💚 shadedjars 10m 55s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 4m 55s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 24s Maven dependency ordering for patch
+1 💚 mvninstall 5m 47s the patch passed
+1 💚 compile 3m 30s the patch passed
+1 💚 javac 3m 30s the patch passed
+1 💚 shadedjars 8m 24s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 4m 11s the patch passed
_ Other Tests _
+1 💚 unit 189m 55s root in the patch passed.
247m 14s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4091/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #4091
Optional Tests javac javadoc unit shadedjars compile
uname Linux 1030e1d7ce10 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 3da23c2
Default Java AdoptOpenJDK-11.0.10+9
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4091/2/testReport/
Max. process+thread count 6586 (vs. ulimit of 30000)
modules C: hbase-resource-bundle hbase-http hbase-shaded hbase-shaded/hbase-shaded-client hbase-shaded/hbase-shaded-testing-util . U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4091/2/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 4m 6s Docker mode activated.
-0 ⚠️ yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 21s Maven dependency ordering for branch
+1 💚 mvninstall 3m 52s master passed
+1 💚 compile 2m 48s master passed
+1 💚 shadedjars 9m 53s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 3m 41s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 21s Maven dependency ordering for patch
+1 💚 mvninstall 4m 6s the patch passed
+1 💚 compile 2m 50s the patch passed
+1 💚 javac 2m 50s the patch passed
+1 💚 shadedjars 8m 31s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 3m 31s the patch passed
_ Other Tests _
-1 ❌ unit 370m 1s root in the patch failed.
417m 18s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4091/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #4091
Optional Tests javac javadoc unit shadedjars compile
uname Linux 1e54732c5bbe 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 3da23c2
Default Java AdoptOpenJDK-1.8.0_282-b08
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4091/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4091/2/testReport/
Max. process+thread count 5400 (vs. ulimit of 30000)
modules C: hbase-resource-bundle hbase-http hbase-shaded hbase-shaded/hbase-shaded-client hbase-shaded/hbase-shaded-testing-util . U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-4091/2/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache9
Copy link
Contributor

Apache9 commented Feb 19, 2022

Oh, I think the content is good, but I think think we'd better have another jira issue for landing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants