Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBASE-26717 [hbase-thirdparty] hbase-shaded-jersey packages unshaded classes #73

Open
wants to merge 1 commit into
base: branch-3
Choose a base branch
from

Conversation

apurtell
Copy link
Contributor

@apurtell apurtell commented Feb 2, 2022

No description provided.

@apurtell apurtell requested review from busbey and Apache9 February 2, 2022 01:13
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 48s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-0 ⚠️ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-3 Compile Tests _
+1 💚 mvninstall 0m 51s branch-3 passed
+1 💚 compile 0m 5s branch-3 passed
+1 💚 javadoc 0m 6s branch-3 passed
_ Patch Compile Tests _
+1 💚 mvninstall 0m 9s the patch passed
+1 💚 compile 0m 4s the patch passed
+1 💚 javac 0m 4s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 1s The patch has no ill-formed XML file.
+1 💚 javadoc 0m 4s the patch passed
_ Other Tests _
+1 💚 unit 0m 5s hbase-shaded-jersey in the patch passed.
+1 💚 asflicense 0m 7s The patch does not generate ASF License warnings.
2m 28s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-Thirdparty-PreCommit/job/PR-73/1/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR #73
Optional Tests dupname asflicense javac javadoc unit xml compile
uname Linux 7e36ae9fc6b8 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 GNU/Linux
Build tool maven
git revision branch-3 / 976e7a8
Default Java Oracle Corporation-1.8.0_282-b08
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-Thirdparty-PreCommit/job/PR-73/1/testReport/
Max. process+thread count 39 (vs. ulimit of 1000)
modules C: hbase-shaded-jersey U: hbase-shaded-jersey
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-Thirdparty-PreCommit/job/PR-73/1/console
versions git=2.20.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@busbey busbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're missing the jdk11+ activation for hbase-shaded-jersey that adds in the compatibility jars from jakarta.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 16s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-0 ⚠️ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-3 Compile Tests _
+1 💚 mvninstall 0m 43s branch-3 passed
+1 💚 compile 0m 6s branch-3 passed
+1 💚 javadoc 0m 6s branch-3 passed
_ Patch Compile Tests _
+1 💚 mvninstall 0m 9s the patch passed
+1 💚 compile 0m 5s the patch passed
+1 💚 javac 0m 5s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 1s The patch has no ill-formed XML file.
+1 💚 javadoc 0m 4s the patch passed
_ Other Tests _
+1 💚 unit 0m 5s hbase-shaded-jersey in the patch passed.
+1 💚 asflicense 0m 5s The patch does not generate ASF License warnings.
2m 48s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-73/1/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR #73
Optional Tests dupname asflicense javac javadoc unit xml compile
uname Linux 5deb8caca367 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 GNU/Linux
Build tool maven
git revision branch-3 / 5d302c3
Default Java Oracle Corporation-1.8.0_282-b08
Test Results https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-73/1/testReport/
Max. process+thread count 39 (vs. ulimit of 1000)
modules C: hbase-shaded-jersey U: hbase-shaded-jersey
Console output https://ci-hbase.apache.org/job/HBase-Thirdparty-PreCommit/job/PR-73/1/console
versions git=2.20.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache9
Copy link
Contributor

Apache9 commented Jun 17, 2022

Any updates here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants