Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-26468 Region Server doesn't exit cleanly incase it crashes. #3866

Merged
merged 1 commit into from
Dec 1, 2021
Merged

HBASE-26468 Region Server doesn't exit cleanly incase it crashes. #3866

merged 1 commit into from
Dec 1, 2021

Conversation

shahrs87
Copy link
Contributor

No description provided.

virajjasani
virajjasani approved these changes Nov 20, 2021
View reviewed changes
Copy link
Contributor

@virajjasani virajjasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, pending QA

@virajjasani virajjasani mentioned this pull request Nov 20, 2021
Merged
@virajjasani virajjasani added the backport This PR is a back port of some issue or issues already committed to master label Nov 20, 2021
@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 8m 3s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-0 ⚠️ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-1 Compile Tests _
+1 💚 mvninstall 10m 34s branch-1 passed
+1 💚 compile 0m 46s branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚 compile 0m 51s branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚 checkstyle 1m 56s branch-1 passed
+1 💚 shadedjars 4m 23s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 59s branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚 javadoc 0m 52s branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+0 🆗 spotbugs 3m 38s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 3m 34s branch-1 passed
_ Patch Compile Tests _
+1 💚 mvninstall 2m 47s the patch passed
+1 💚 compile 0m 57s the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚 javac 0m 57s the patch passed
+1 💚 compile 0m 59s the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚 javac 0m 59s the patch passed
+1 💚 checkstyle 1m 50s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedjars 3m 51s patch has no errors when building our shaded downstream artifacts.
+1 💚 hadoopcheck 6m 8s Patch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1 💚 javadoc 0m 34s the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚 javadoc 0m 45s the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚 findbugs 3m 15s the patch passed
_ Other Tests _
-1 ❌ unit 157m 26s hbase-server in the patch failed.
+1 💚 asflicense 0m 34s The patch does not generate ASF License warnings.
215m 11s
Reason Tests
Failed junit tests hadoop.hbase.replication.TestMasterReplication
hadoop.hbase.mapreduce.TestLoadIncrementalHFiles
hadoop.hbase.mapreduce.TestLoadIncrementalHFilesUseSecurityEndPoint
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3866/1/artifact/out/Dockerfile
GITHUB PR #3866
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux bc10bdf61f0e 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-home/workspace/Base-PreCommit-GitHub-PR_PR-3866/out/precommit/personality/provided.sh
git revision branch-1 / 0d214ff
Default Java Azul Systems, Inc.-1.7.0_272-b10
Multi-JDK versions /usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3866/1/artifact/out/patch-unit-hbase-server.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3866/1/testReport/
Max. process+thread count 3970 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3866/1/console
versions git=2.17.1 maven=3.6.0 findbugs=3.0.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@shahrs87 shahrs87 force-pushed the HBASE-26468-branch-1 branch from 37f068a to ac26674 Compare November 30, 2021 15:50
shahrs87
shahrs87 commented Nov 30, 2021
View reviewed changes
hbase-common/src/main/java/org/apache/hadoop/hbase/util/Threads.java
public static boolean isNonDaemonThreadRunning() {
AtomicInteger nonDaemonThreadCount = new AtomicInteger();
Set<Thread> threads = Thread.getAllStackTraces().keySet();
for (Thread t: threads) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a small difference between master patch and branch-1 patch.

  1. Replaced threads.forEach(t -> { with for (Thread t: threads)
  2. Replaced org.apache.commons.logging.Log with org.slf4j.LoggerFactory since the former doesn't allow String formatter.

Cc @virajjasani

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 57s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-0 ⚠️ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-1 Compile Tests _
+0 🆗 mvndep 2m 33s Maven dependency ordering for branch
+1 💚 mvninstall 8m 43s branch-1 passed
+1 💚 compile 1m 7s branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚 compile 1m 11s branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚 checkstyle 2m 4s branch-1 passed
+1 💚 shadedjars 3m 12s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 1s branch-1 passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚 javadoc 1m 8s branch-1 passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+0 🆗 spotbugs 2m 47s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 4m 5s branch-1 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 18s Maven dependency ordering for patch
+1 💚 mvninstall 2m 5s the patch passed
+1 💚 compile 1m 4s the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚 javac 1m 4s the patch passed
+1 💚 compile 1m 12s the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚 javac 1m 12s the patch passed
-1 ❌ checkstyle 1m 30s hbase-server: The patch generated 1 new + 3 unchanged - 0 fixed = 4 total (was 3)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedjars 3m 6s patch has no errors when building our shaded downstream artifacts.
+1 💚 hadoopcheck 5m 3s Patch does not cause any errors with Hadoop 2.8.5 2.9.2.
+1 💚 javadoc 0m 51s the patch passed with JDK Azul Systems, Inc.-1.8.0_262-b19
+1 💚 javadoc 1m 6s the patch passed with JDK Azul Systems, Inc.-1.7.0_272-b10
+1 💚 findbugs 4m 9s the patch passed
_ Other Tests _
+1 💚 unit 2m 59s hbase-common in the patch passed.
+1 💚 unit 132m 57s hbase-server in the patch passed.
+1 💚 asflicense 0m 58s The patch does not generate ASF License warnings.
188m 8s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3866/2/artifact/out/Dockerfile
GITHUB PR #3866
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux b98ea0115e3d 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-agent/workspace/Base-PreCommit-GitHub-PR_PR-3866/out/precommit/personality/provided.sh
git revision branch-1 / 13787ae
Default Java Azul Systems, Inc.-1.7.0_272-b10
Multi-JDK versions /usr/lib/jvm/zulu-8-amd64:Azul Systems, Inc.-1.8.0_262-b19 /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_272-b10
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3866/2/artifact/out/diff-checkstyle-hbase-server.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3866/2/testReport/
Max. process+thread count 4470 (vs. ulimit of 10000)
modules C: hbase-common hbase-server U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3866/2/console
versions git=2.17.1 maven=3.6.0 findbugs=3.0.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

virajjasani
virajjasani approved these changes Dec 1, 2021
View reviewed changes
Copy link
Contributor

@virajjasani virajjasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for the backport

@virajjasani virajjasani merged commit 7192423 into apache:branch-1 Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@virajjasani virajjasani virajjasani approved these changes

Assignees
No one assigned
Labels
backport This PR is a back port of some issue or issues already committed to master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shahrs87 @Apache-HBase @virajjasani