-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
HBASE-26433 Rollback from ZK-less to ZK-based assignment could produc…
…e inconsistent state - doubly assigned regions (#3826) Signed-off-by: Andrew Purtell <[email protected]> Signed-off-by: Geoffrey Jacoby <[email protected]> Signed-off-by: David Manning <[email protected]>
- Loading branch information
1 parent
40b4cb1
commit 0d214ff
Showing
5 changed files
with
173 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
92 changes: 92 additions & 0 deletions
92
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestZKLessAssignment.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,92 @@ | ||
| /* | ||
| * | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.hadoop.hbase.client; | ||
|
|
||
| import java.util.List; | ||
| import org.junit.Assert; | ||
| import org.junit.Test; | ||
| import org.junit.experimental.categories.Category; | ||
| import org.apache.hadoop.conf.Configuration; | ||
| import org.apache.hadoop.hbase.Cell; | ||
| import org.apache.hadoop.hbase.HBaseTestingUtility; | ||
| import org.apache.hadoop.hbase.HConstants; | ||
| import org.apache.hadoop.hbase.MetaTableAccessor; | ||
| import org.apache.hadoop.hbase.TableName; | ||
| import org.apache.hadoop.hbase.testclassification.LargeTests; | ||
| import org.apache.hadoop.hbase.util.Bytes; | ||
|
|
||
| @Category({ LargeTests.class}) | ||
| public class TestZKLessAssignment { | ||
|
|
||
| private final static HBaseTestingUtility TEST_UTIL = new HBaseTestingUtility(); | ||
|
|
||
| @Test | ||
| public void testZkLessAssignmentRollbackAndRollForward() throws Exception { | ||
| Configuration config = TEST_UTIL.getConfiguration(); | ||
| config.setBoolean("hbase.assignment.usezk.migrating", true); | ||
| TEST_UTIL.startMiniCluster(2); | ||
| TableName tableName = TableName.valueOf("testZkLessAssignmentRollbackAndRollForward"); | ||
| TEST_UTIL.createTable(tableName.getName(), new byte[][] { Bytes.toBytes("cf1") }, config) | ||
| .close(); | ||
|
|
||
| try (Connection connection = ConnectionFactory.createConnection(config)) { | ||
| List<Result> results = MetaTableAccessor.fullScanOfMeta(connection); | ||
| boolean isSNQualifierExist = false; | ||
| boolean isStateQualifierExist = false; | ||
| for (Result result : results) { | ||
| Cell cell = | ||
| result.getColumnLatestCell(HConstants.CATALOG_FAMILY, HConstants.SERVERNAME_QUALIFIER); | ||
| if (cell != null && cell.getValueLength() > 0) { | ||
| isSNQualifierExist = true; | ||
| } | ||
| cell = result.getColumnLatestCell(HConstants.CATALOG_FAMILY, HConstants.STATE_QUALIFIER); | ||
| if (cell != null && cell.getValueLength() > 0) { | ||
| isStateQualifierExist = true; | ||
| } | ||
| } | ||
| Assert.assertTrue(isSNQualifierExist); | ||
| Assert.assertTrue(isStateQualifierExist); | ||
| } | ||
|
|
||
| TEST_UTIL.shutdownMiniHBaseCluster(); | ||
| config.unset("hbase.assignment.usezk.migrating"); | ||
| TEST_UTIL.restartHBaseCluster(2); | ||
|
|
||
| try (Connection connection = ConnectionFactory.createConnection(config)) { | ||
| List<Result> results = MetaTableAccessor.fullScanOfMeta(connection); | ||
| boolean isSNQualifierExist = false; | ||
| boolean isStateQualifierExist = false; | ||
| for (Result result : results) { | ||
| Cell cell = | ||
| result.getColumnLatestCell(HConstants.CATALOG_FAMILY, HConstants.SERVERNAME_QUALIFIER); | ||
| if (cell != null && cell.getValueLength() > 0) { | ||
| isSNQualifierExist = true; | ||
| } | ||
| cell = result.getColumnLatestCell(HConstants.CATALOG_FAMILY, HConstants.STATE_QUALIFIER); | ||
| if (cell != null && cell.getValueLength() > 0) { | ||
| isStateQualifierExist = true; | ||
| } | ||
| } | ||
| Assert.assertFalse(isSNQualifierExist); | ||
| Assert.assertFalse(isStateQualifierExist); | ||
| } | ||
| } | ||
|
|
||
| } |