-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-22664 Move protobuf stuff in hbase-rsgroup to hbase-protocol-sh… #362
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| /** | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package hbase.pb; | ||
|
|
||
| option java_package = "org.apache.hadoop.hbase.shaded.protobuf.generated"; | ||
| option java_outer_classname = "RSGroupProtos"; | ||
| option java_generic_services = true; | ||
| option java_generate_equals_and_hash = true; | ||
| option optimize_for = SPEED; | ||
|
|
||
| import "HBase.proto"; | ||
|
|
||
| message RSGroupInfo { | ||
| required string name = 1; | ||
| repeated ServerName servers = 4; | ||
| repeated TableName tables = 3; | ||
| } |
158 changes: 158 additions & 0 deletions
158
hbase-protocol-shaded/src/main/protobuf/RSGroupAdmin.proto
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,158 @@ | ||
| /** | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package hbase.pb; | ||
|
|
||
| option java_package = "org.apache.hadoop.hbase.shaded.protobuf.generated"; | ||
| option java_outer_classname = "RSGroupAdminProtos"; | ||
| option java_generic_services = true; | ||
| option java_generate_equals_and_hash = true; | ||
| option optimize_for = SPEED; | ||
|
|
||
| import "HBase.proto"; | ||
| import "RSGroup.proto"; | ||
|
|
||
| /** Group level protobufs */ | ||
|
|
||
| message ListTablesOfRSGroupRequest { | ||
| required string r_s_group_name = 1; | ||
| } | ||
|
|
||
| message ListTablesOfRSGroupResponse { | ||
| repeated TableName table_name = 1; | ||
| } | ||
|
|
||
| message GetRSGroupInfoRequest { | ||
| required string r_s_group_name = 1; | ||
| } | ||
|
|
||
| message GetRSGroupInfoResponse { | ||
| optional RSGroupInfo r_s_group_info = 1; | ||
| } | ||
|
|
||
| message GetRSGroupInfoOfTableRequest { | ||
| required TableName table_name = 1; | ||
| } | ||
|
|
||
| message GetRSGroupInfoOfTableResponse { | ||
| optional RSGroupInfo r_s_group_info = 1; | ||
| } | ||
|
|
||
| message MoveServersRequest { | ||
| required string target_group = 1; | ||
| repeated ServerName servers = 3; | ||
| } | ||
|
|
||
| message MoveServersResponse { | ||
| } | ||
|
|
||
| message MoveTablesRequest { | ||
| required string target_group = 1; | ||
| repeated TableName table_name = 2; | ||
| } | ||
|
|
||
| message MoveTablesResponse { | ||
| } | ||
|
|
||
| message AddRSGroupRequest { | ||
| required string r_s_group_name = 1; | ||
| } | ||
|
|
||
| message AddRSGroupResponse { | ||
| } | ||
|
|
||
| message RemoveRSGroupRequest { | ||
| required string r_s_group_name = 1; | ||
| } | ||
|
|
||
| message RemoveRSGroupResponse { | ||
| } | ||
|
|
||
| message BalanceRSGroupRequest { | ||
| required string r_s_group_name = 1; | ||
| } | ||
|
|
||
| message BalanceRSGroupResponse { | ||
| required bool balanceRan = 1; | ||
| } | ||
|
|
||
| message ListRSGroupInfosRequest { | ||
| } | ||
|
|
||
| message ListRSGroupInfosResponse { | ||
| repeated RSGroupInfo r_s_group_info = 1; | ||
| } | ||
|
|
||
| message GetRSGroupInfoOfServerRequest { | ||
| required ServerName server = 2; | ||
| } | ||
|
|
||
| message GetRSGroupInfoOfServerResponse { | ||
| optional RSGroupInfo r_s_group_info = 1; | ||
| } | ||
|
|
||
| message MoveServersAndTablesRequest { | ||
| required string target_group = 1; | ||
| repeated ServerName servers = 2; | ||
| repeated TableName table_name = 3; | ||
| } | ||
|
|
||
| message MoveServersAndTablesResponse { | ||
| } | ||
|
|
||
| message RemoveServersRequest { | ||
| repeated ServerName servers = 1; | ||
| } | ||
|
|
||
| message RemoveServersResponse { | ||
| } | ||
|
|
||
| service RSGroupAdminService { | ||
| rpc GetRSGroupInfo(GetRSGroupInfoRequest) | ||
| returns (GetRSGroupInfoResponse); | ||
|
|
||
| rpc GetRSGroupInfoOfTable(GetRSGroupInfoOfTableRequest) | ||
| returns (GetRSGroupInfoOfTableResponse); | ||
|
|
||
| rpc GetRSGroupInfoOfServer(GetRSGroupInfoOfServerRequest) | ||
| returns (GetRSGroupInfoOfServerResponse); | ||
|
|
||
| rpc MoveServers(MoveServersRequest) | ||
| returns (MoveServersResponse); | ||
|
|
||
| rpc MoveTables(MoveTablesRequest) | ||
| returns (MoveTablesResponse); | ||
|
|
||
| rpc AddRSGroup(AddRSGroupRequest) | ||
| returns (AddRSGroupResponse); | ||
|
|
||
| rpc RemoveRSGroup(RemoveRSGroupRequest) | ||
| returns (RemoveRSGroupResponse); | ||
|
|
||
| rpc BalanceRSGroup(BalanceRSGroupRequest) | ||
| returns (BalanceRSGroupResponse); | ||
|
|
||
| rpc ListRSGroupInfos(ListRSGroupInfosRequest) | ||
| returns (ListRSGroupInfosResponse); | ||
|
|
||
| rpc MoveServersAndTables(MoveServersAndTablesRequest) | ||
| returns (MoveServersAndTablesResponse); | ||
|
|
||
| rpc RemoveServers(RemoveServersRequest) | ||
| returns (RemoveServersResponse); | ||
| } |
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method should be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At least we still need it for now as it is referenced in lots of places. Not sure if we can remove it at the end. FWIW, I think we still need to support the old way to change rsgroup, which uses coprocessor endpoint?